Commit 230f5a89 authored by Dan Williams's avatar Dan Williams

dax: fix vma_is_fsdax() helper

Gerd reports that ->i_mode may contain other bits besides S_IFCHR. Use
S_ISCHR() instead. Otherwise, get_user_pages_longterm() may fail on
device-dax instances when those are meant to be explicitly allowed.

Fixes: 2bb6d283 ("mm: introduce get_user_pages_longterm")
Cc: <stable@vger.kernel.org>
Reported-by: default avatarGerd Rausch <gerd.rausch@oracle.com>
Acked-by: default avatarJane Chu <jane.chu@oracle.com>
Reported-by: default avatarHaozhong Zhang <haozhong.zhang@intel.com>
Reviewed-by: default avatarJan Kara <jack@suse.cz>
Signed-off-by: default avatarDan Williams <dan.j.williams@intel.com>
parent 9d4949b4
...@@ -3198,7 +3198,7 @@ static inline bool vma_is_fsdax(struct vm_area_struct *vma) ...@@ -3198,7 +3198,7 @@ static inline bool vma_is_fsdax(struct vm_area_struct *vma)
if (!vma_is_dax(vma)) if (!vma_is_dax(vma))
return false; return false;
inode = file_inode(vma->vm_file); inode = file_inode(vma->vm_file);
if (inode->i_mode == S_IFCHR) if (S_ISCHR(inode->i_mode))
return false; /* device-dax */ return false; /* device-dax */
return true; return true;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment