Commit 2429b3c5 authored by Nur Hussein's avatar Nur Hussein Committed by Thierry Reding

drm/tegra: Avoid potential 32-bit integer overflow

In tegra_sor_compute_config(), the 32-bit value mode->clock is
multiplied by 1000, and assigned to the u64 variable pclk. We can avoid
a potential 32-bit integer overflow by casting mode->clock to u64 before
we do the arithmetic and assignment.
Signed-off-by: default avatarNur Hussein <hussein@unixcat.org>
Signed-off-by: default avatarThierry Reding <treding@nvidia.com>
parent 71ec16f4
...@@ -1153,7 +1153,7 @@ static int tegra_sor_compute_config(struct tegra_sor *sor, ...@@ -1153,7 +1153,7 @@ static int tegra_sor_compute_config(struct tegra_sor *sor,
struct drm_dp_link *link) struct drm_dp_link *link)
{ {
const u64 f = 100000, link_rate = link->rate * 1000; const u64 f = 100000, link_rate = link->rate * 1000;
const u64 pclk = mode->clock * 1000; const u64 pclk = (u64)mode->clock * 1000;
u64 input, output, watermark, num; u64 input, output, watermark, num;
struct tegra_sor_params params; struct tegra_sor_params params;
u32 num_syms_per_line; u32 num_syms_per_line;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment