Commit 24e894bb authored by Ian Abbott's avatar Ian Abbott Committed by Greg Kroah-Hartman

staging: comedi: pass subdevice to comedi_buf_write_alloc()

Change the parameters of `comedi_buf_write_alloc()` to pass a pointer to
the comedi subdevice instead of a pointer to the "async" structure
belonging to the subdevice.

The main aim at the moment is to replace all the `struct comedi_async *`
parameters with `struct comedi_subdevice *` parameters in the comedi
driver API.
Signed-off-by: default avatarIan Abbott <abbotti@mev.co.uk>
Reviewed-by: default avatarH Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 67ab76f0
...@@ -269,10 +269,10 @@ static unsigned int __comedi_buf_write_alloc(struct comedi_async *async, ...@@ -269,10 +269,10 @@ static unsigned int __comedi_buf_write_alloc(struct comedi_async *async,
} }
/* allocates chunk for the writer from free buffer space */ /* allocates chunk for the writer from free buffer space */
unsigned int comedi_buf_write_alloc(struct comedi_async *async, unsigned int comedi_buf_write_alloc(struct comedi_subdevice *s,
unsigned int nbytes) unsigned int nbytes)
{ {
return __comedi_buf_write_alloc(async, nbytes, 0); return __comedi_buf_write_alloc(s->async, nbytes, 0);
} }
EXPORT_SYMBOL_GPL(comedi_buf_write_alloc); EXPORT_SYMBOL_GPL(comedi_buf_write_alloc);
......
...@@ -1004,7 +1004,7 @@ static int do_bufinfo_ioctl(struct comedi_device *dev, ...@@ -1004,7 +1004,7 @@ static int do_bufinfo_ioctl(struct comedi_device *dev,
if (bi.bytes_written && (s->subdev_flags & SDF_CMD_WRITE)) { if (bi.bytes_written && (s->subdev_flags & SDF_CMD_WRITE)) {
bi.bytes_written = bi.bytes_written =
comedi_buf_write_alloc(async, bi.bytes_written); comedi_buf_write_alloc(s, bi.bytes_written);
comedi_buf_write_free(async, bi.bytes_written); comedi_buf_write_free(async, bi.bytes_written);
} }
...@@ -2038,7 +2038,7 @@ static unsigned int comedi_poll(struct file *file, poll_table *wait) ...@@ -2038,7 +2038,7 @@ static unsigned int comedi_poll(struct file *file, poll_table *wait)
unsigned int bps = bytes_per_sample(s); unsigned int bps = bytes_per_sample(s);
poll_wait(file, &s->async->wait_head, wait); poll_wait(file, &s->async->wait_head, wait);
comedi_buf_write_alloc(s->async, s->async->prealloc_bufsz); comedi_buf_write_alloc(s, s->async->prealloc_bufsz);
if (!s->busy || !comedi_is_subdevice_running(s) || if (!s->busy || !comedi_is_subdevice_running(s) ||
comedi_buf_write_n_allocated(s->async) >= bps) comedi_buf_write_n_allocated(s->async) >= bps)
mask |= POLLOUT | POLLWRNORM; mask |= POLLOUT | POLLWRNORM;
...@@ -2136,7 +2136,7 @@ static ssize_t comedi_write(struct file *file, const char __user *buf, ...@@ -2136,7 +2136,7 @@ static ssize_t comedi_write(struct file *file, const char __user *buf,
m = n; m = n;
if (async->buf_write_ptr + m > async->prealloc_bufsz) if (async->buf_write_ptr + m > async->prealloc_bufsz)
m = async->prealloc_bufsz - async->buf_write_ptr; m = async->prealloc_bufsz - async->buf_write_ptr;
comedi_buf_write_alloc(async, async->prealloc_bufsz); comedi_buf_write_alloc(s, async->prealloc_bufsz);
if (m > comedi_buf_write_n_allocated(async)) if (m > comedi_buf_write_n_allocated(async))
m = comedi_buf_write_n_allocated(async); m = comedi_buf_write_n_allocated(async);
if (m < n) if (m < n)
......
...@@ -336,7 +336,7 @@ static inline unsigned int bytes_per_sample(const struct comedi_subdevice *subd) ...@@ -336,7 +336,7 @@ static inline unsigned int bytes_per_sample(const struct comedi_subdevice *subd)
*/ */
int comedi_set_hw_dev(struct comedi_device *dev, struct device *hw_dev); int comedi_set_hw_dev(struct comedi_device *dev, struct device *hw_dev);
unsigned int comedi_buf_write_alloc(struct comedi_async *, unsigned int); unsigned int comedi_buf_write_alloc(struct comedi_subdevice *s, unsigned int n);
unsigned int comedi_buf_write_free(struct comedi_async *, unsigned int); unsigned int comedi_buf_write_free(struct comedi_async *, unsigned int);
unsigned int comedi_buf_read_n_available(struct comedi_async *); unsigned int comedi_buf_read_n_available(struct comedi_async *);
......
...@@ -2702,8 +2702,7 @@ static int i_APCI3200_InterruptHandleEos(struct comedi_device *dev) ...@@ -2702,8 +2702,7 @@ static int i_APCI3200_InterruptHandleEos(struct comedi_device *dev)
s->async->events |= COMEDI_CB_EOS; s->async->events |= COMEDI_CB_EOS;
/* Test if enougth memory is available and allocate it for 7 values */ /* Test if enougth memory is available and allocate it for 7 values */
/* n = comedi_buf_write_alloc(s->async, 7*sizeof(unsigned int)); */ n = comedi_buf_write_alloc(s,
n = comedi_buf_write_alloc(s->async,
(7 + 12) * sizeof(unsigned int)); (7 + 12) * sizeof(unsigned int));
/* If not enough memory available, event is set to Comedi Buffer Error */ /* If not enough memory available, event is set to Comedi Buffer Error */
......
...@@ -67,7 +67,7 @@ unsigned int cfc_write_array_to_buffer(struct comedi_subdevice *s, ...@@ -67,7 +67,7 @@ unsigned int cfc_write_array_to_buffer(struct comedi_subdevice *s,
if (num_bytes == 0) if (num_bytes == 0)
return 0; return 0;
retval = comedi_buf_write_alloc(async, num_bytes); retval = comedi_buf_write_alloc(s, num_bytes);
if (retval != num_bytes) { if (retval != num_bytes) {
dev_warn(s->device->class_dev, "buffer overrun\n"); dev_warn(s->device->class_dev, "buffer overrun\n");
async->events |= COMEDI_CB_OVERFLOW; async->events |= COMEDI_CB_OVERFLOW;
......
...@@ -533,7 +533,7 @@ int mite_sync_input_dma(struct mite_channel *mite_chan, ...@@ -533,7 +533,7 @@ int mite_sync_input_dma(struct mite_channel *mite_chan,
old_alloc_count = async->buf_write_alloc_count; old_alloc_count = async->buf_write_alloc_count;
/* write alloc as much as we can */ /* write alloc as much as we can */
comedi_buf_write_alloc(async, async->prealloc_bufsz); comedi_buf_write_alloc(s, async->prealloc_bufsz);
nbytes = mite_bytes_written_to_memory_lb(mite_chan); nbytes = mite_bytes_written_to_memory_lb(mite_chan);
if ((int)(mite_bytes_written_to_memory_ub(mite_chan) - if ((int)(mite_bytes_written_to_memory_ub(mite_chan) -
......
...@@ -1505,7 +1505,7 @@ static int ni_ai_setup_MITE_dma(struct comedi_device *dev) ...@@ -1505,7 +1505,7 @@ static int ni_ai_setup_MITE_dma(struct comedi_device *dev)
/* printk("comedi_debug: using mite channel %i for ai.\n", devpriv->ai_mite_chan->channel); */ /* printk("comedi_debug: using mite channel %i for ai.\n", devpriv->ai_mite_chan->channel); */
/* write alloc the entire buffer */ /* write alloc the entire buffer */
comedi_buf_write_alloc(s->async, s->async->prealloc_bufsz); comedi_buf_write_alloc(s, s->async->prealloc_bufsz);
spin_lock_irqsave(&devpriv->mite_channel_lock, flags); spin_lock_irqsave(&devpriv->mite_channel_lock, flags);
if (devpriv->ai_mite_chan == NULL) { if (devpriv->ai_mite_chan == NULL) {
......
...@@ -759,7 +759,7 @@ static int setup_mite_dma(struct comedi_device *dev, struct comedi_subdevice *s) ...@@ -759,7 +759,7 @@ static int setup_mite_dma(struct comedi_device *dev, struct comedi_subdevice *s)
return retval; return retval;
/* write alloc the entire buffer */ /* write alloc the entire buffer */
comedi_buf_write_alloc(s->async, s->async->prealloc_bufsz); comedi_buf_write_alloc(s, s->async->prealloc_bufsz);
spin_lock_irqsave(&devpriv->mite_channel_lock, flags); spin_lock_irqsave(&devpriv->mite_channel_lock, flags);
if (devpriv->di_mite_chan) { if (devpriv->di_mite_chan) {
......
...@@ -125,7 +125,7 @@ static int ni_tio_input_cmd(struct comedi_subdevice *s) ...@@ -125,7 +125,7 @@ static int ni_tio_input_cmd(struct comedi_subdevice *s)
int retval = 0; int retval = 0;
/* write alloc the entire buffer */ /* write alloc the entire buffer */
comedi_buf_write_alloc(async, async->prealloc_bufsz); comedi_buf_write_alloc(s, async->prealloc_bufsz);
counter->mite_chan->dir = COMEDI_INPUT; counter->mite_chan->dir = COMEDI_INPUT;
switch (counter_dev->variant) { switch (counter_dev->variant) {
case ni_gpct_variant_m_series: case ni_gpct_variant_m_series:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment