Commit 24f2cd01 authored by Jiri Slaby (SUSE)'s avatar Jiri Slaby (SUSE) Committed by Greg Kroah-Hartman

tty: use 'if' in send_break() instead of 'goto'

Now, the "jumped-over" code is simple enough to be put inside an 'if'.
Do so to make it 'goto'-less.
Signed-off-by: default avatar"Jiri Slaby (SUSE)" <jirislaby@kernel.org>
Link: https://lore.kernel.org/r/20230919085156.1578-16-jirislaby@kernel.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent fd99392b
......@@ -2482,11 +2482,10 @@ static int send_break(struct tty_struct *tty, unsigned int duration)
return -EINTR;
retval = tty->ops->break_ctl(tty, -1);
if (retval)
goto out;
msleep_interruptible(duration);
retval = tty->ops->break_ctl(tty, 0);
out:
if (!retval) {
msleep_interruptible(duration);
retval = tty->ops->break_ctl(tty, 0);
}
tty_write_unlock(tty);
if (signal_pending(current))
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment