Commit 259b3633 authored by Hui Su's avatar Hui Su Committed by Linus Torvalds

mm/oom_kill: change comment and rename is_dump_unreclaim_slabs()

Change the comment of is_dump_unreclaim_slabs(), it just check whether
nr_unreclaimable slabs amount is greater than user memory, and explain why
we dump unreclaim slabs.

Rename it to should_dump_unreclaim_slab() maybe better.

Link: https://lkml.kernel.org/r/20201030182704.GA53949@rlkSigned-off-by: default avatarHui Su <sh_def@163.com>
Acked-by: default avatarMichal Hocko <mhocko@suse.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 2271b016
...@@ -170,11 +170,13 @@ static bool oom_unkillable_task(struct task_struct *p) ...@@ -170,11 +170,13 @@ static bool oom_unkillable_task(struct task_struct *p)
return false; return false;
} }
/* /**
* Print out unreclaimble slabs info when unreclaimable slabs amount is greater * Check whether unreclaimable slab amount is greater than
* than all user memory (LRU pages) * all user memory(LRU pages).
*/ * dump_unreclaimable_slab() could help in the case that
static bool is_dump_unreclaim_slabs(void) * oom due to too much unreclaimable slab used by kernel.
*/
static bool should_dump_unreclaim_slab(void)
{ {
unsigned long nr_lru; unsigned long nr_lru;
...@@ -463,7 +465,7 @@ static void dump_header(struct oom_control *oc, struct task_struct *p) ...@@ -463,7 +465,7 @@ static void dump_header(struct oom_control *oc, struct task_struct *p)
mem_cgroup_print_oom_meminfo(oc->memcg); mem_cgroup_print_oom_meminfo(oc->memcg);
else { else {
show_mem(SHOW_MEM_FILTER_NODES, oc->nodemask); show_mem(SHOW_MEM_FILTER_NODES, oc->nodemask);
if (is_dump_unreclaim_slabs()) if (should_dump_unreclaim_slab())
dump_unreclaimable_slab(); dump_unreclaimable_slab();
} }
if (sysctl_oom_dump_tasks) if (sysctl_oom_dump_tasks)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment