Commit 25a64ac9 authored by Mats Randgaard's avatar Mats Randgaard Committed by Mauro Carvalho Chehab

[media] adv7604: debounce "format change" notifications

The bridge driver is only notified when the input status has changed
since the previous interrupt.
Signed-off-by: default avatarMats Randgaard <matrandg@cisco.com>
Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
parent c3e75c7d
...@@ -77,6 +77,7 @@ struct adv7604_state { ...@@ -77,6 +77,7 @@ struct adv7604_state {
struct delayed_work delayed_work_enable_hotplug; struct delayed_work delayed_work_enable_hotplug;
bool connector_hdmi; bool connector_hdmi;
bool restart_stdi_once; bool restart_stdi_once;
u32 prev_input_status;
/* i2c clients */ /* i2c clients */
struct i2c_client *i2c_avlink; struct i2c_client *i2c_avlink;
...@@ -1535,6 +1536,7 @@ static int adv7604_isr(struct v4l2_subdev *sd, u32 status, bool *handled) ...@@ -1535,6 +1536,7 @@ static int adv7604_isr(struct v4l2_subdev *sd, u32 status, bool *handled)
{ {
struct adv7604_state *state = to_state(sd); struct adv7604_state *state = to_state(sd);
u8 fmt_change, fmt_change_digital, tx_5v; u8 fmt_change, fmt_change_digital, tx_5v;
u32 input_status;
/* format change */ /* format change */
fmt_change = io_read(sd, 0x43) & 0x98; fmt_change = io_read(sd, 0x43) & 0x98;
...@@ -1545,9 +1547,18 @@ static int adv7604_isr(struct v4l2_subdev *sd, u32 status, bool *handled) ...@@ -1545,9 +1547,18 @@ static int adv7604_isr(struct v4l2_subdev *sd, u32 status, bool *handled)
io_write(sd, 0x6c, fmt_change_digital); io_write(sd, 0x6c, fmt_change_digital);
if (fmt_change || fmt_change_digital) { if (fmt_change || fmt_change_digital) {
v4l2_dbg(1, debug, sd, v4l2_dbg(1, debug, sd,
"%s: ADV7604_FMT_CHANGE, fmt_change = 0x%x, fmt_change_digital = 0x%x\n", "%s: fmt_change = 0x%x, fmt_change_digital = 0x%x\n",
__func__, fmt_change, fmt_change_digital); __func__, fmt_change, fmt_change_digital);
v4l2_subdev_notify(sd, ADV7604_FMT_CHANGE, NULL);
adv7604_g_input_status(sd, &input_status);
if (input_status != state->prev_input_status) {
v4l2_dbg(1, debug, sd,
"%s: input_status = 0x%x, prev_input_status = 0x%x\n",
__func__, input_status, state->prev_input_status);
state->prev_input_status = input_status;
v4l2_subdev_notify(sd, ADV7604_FMT_CHANGE, NULL);
}
if (handled) if (handled)
*handled = true; *handled = true;
} }
...@@ -1953,6 +1964,10 @@ static int adv7604_probe(struct i2c_client *client, ...@@ -1953,6 +1964,10 @@ static int adv7604_probe(struct i2c_client *client,
return -ENOMEM; return -ENOMEM;
} }
/* initialize variables */
state->restart_stdi_once = true;
state->prev_input_status = ~0;
/* platform data */ /* platform data */
if (!pdata) { if (!pdata) {
v4l_err(client, "No platform data!\n"); v4l_err(client, "No platform data!\n");
...@@ -2036,7 +2051,6 @@ static int adv7604_probe(struct i2c_client *client, ...@@ -2036,7 +2051,6 @@ static int adv7604_probe(struct i2c_client *client,
v4l2_err(sd, "failed to create all i2c clients\n"); v4l2_err(sd, "failed to create all i2c clients\n");
goto err_i2c; goto err_i2c;
} }
state->restart_stdi_once = true;
/* work queues */ /* work queues */
state->work_queues = create_singlethread_workqueue(client->name); state->work_queues = create_singlethread_workqueue(client->name);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment