Commit 25bba715 authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman

powerpc/ibmebus: Fix further device reference leaks

commit 815a7141 upstream.

Make sure to drop any reference taken by bus_find_device() when creating
devices during init and driver registration.

Fixes: 55347cc9 ("[POWERPC] ibmebus: Add device creation and bus probing based on of_device")
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent ae4c24b2
...@@ -180,6 +180,7 @@ static int ibmebus_create_device(struct device_node *dn) ...@@ -180,6 +180,7 @@ static int ibmebus_create_device(struct device_node *dn)
static int ibmebus_create_devices(const struct of_device_id *matches) static int ibmebus_create_devices(const struct of_device_id *matches)
{ {
struct device_node *root, *child; struct device_node *root, *child;
struct device *dev;
int ret = 0; int ret = 0;
root = of_find_node_by_path("/"); root = of_find_node_by_path("/");
...@@ -188,9 +189,12 @@ static int ibmebus_create_devices(const struct of_device_id *matches) ...@@ -188,9 +189,12 @@ static int ibmebus_create_devices(const struct of_device_id *matches)
if (!of_match_node(matches, child)) if (!of_match_node(matches, child))
continue; continue;
if (bus_find_device(&ibmebus_bus_type, NULL, child, dev = bus_find_device(&ibmebus_bus_type, NULL, child,
ibmebus_match_node)) ibmebus_match_node);
if (dev) {
put_device(dev);
continue; continue;
}
ret = ibmebus_create_device(child); ret = ibmebus_create_device(child);
if (ret) { if (ret) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment