Commit 25ec6bbb authored by Russell King's avatar Russell King Committed by Mark Brown

ASoC: kirkwood-dma: don't ignore other irq causes on error

Ignoring the real cause of the interrupt is not a good idea; this
behaviour has been observed to bring Dove platforms to silently
lockup.  Instead, on error fall through to the normal interrupt
processing.

This is especially important on Dove platforms as errors are
handled separately, and allows us to clear down the real cause of
the interrupt.
Signed-off-by: default avatarRussell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
parent ae6a5d37
...@@ -71,7 +71,6 @@ static irqreturn_t kirkwood_dma_irq(int irq, void *dev_id) ...@@ -71,7 +71,6 @@ static irqreturn_t kirkwood_dma_irq(int irq, void *dev_id)
printk(KERN_WARNING "%s: got err interrupt 0x%lx\n", printk(KERN_WARNING "%s: got err interrupt 0x%lx\n",
__func__, cause); __func__, cause);
writel(cause, priv->io + KIRKWOOD_ERR_CAUSE); writel(cause, priv->io + KIRKWOOD_ERR_CAUSE);
return IRQ_HANDLED;
} }
/* we've enabled only bytes interrupts ... */ /* we've enabled only bytes interrupts ... */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment