Commit 260e89a6 authored by Frans Klaver's avatar Frans Klaver Committed by Brian Norris

mtd: core: tone down suggestion that dev.parent should be set

add_mtd_device() has a comment suggesting that the caller should have
set dev.parent. This is required to have the parent device symlink show
up in sysfs, but not for proper operation of the mtd device itself.
Currently we have five drivers registering mtd devices during module
initialization, so they don't actually provide a parent device to link
to. That means we cannot WARN_ON() here, as it would trigger false
positives.

Make the comment a bit less firm in its assertion that dev.parent should
be set.
Signed-off-by: default avatarFrans Klaver <fransklaver@gmail.com>
Signed-off-by: default avatarBrian Norris <computersforpeace@gmail.com>
parent f9bcb6dc
...@@ -430,7 +430,7 @@ int add_mtd_device(struct mtd_info *mtd) ...@@ -430,7 +430,7 @@ int add_mtd_device(struct mtd_info *mtd)
} }
/* Caller should have set dev.parent to match the /* Caller should have set dev.parent to match the
* physical device. * physical device, if appropriate.
*/ */
mtd->dev.type = &mtd_devtype; mtd->dev.type = &mtd_devtype;
mtd->dev.class = &mtd_class; mtd->dev.class = &mtd_class;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment