Commit 2643c47f authored by Peter Huewe's avatar Peter Huewe Committed by Greg Kroah-Hartman

staging/csr: Use kmemdup rather than duplicating its implementation

Found with coccicheck.
The semantic patch that makes this change is available
in scripts/coccinelle/api/memdup.cocci.
Signed-off-by: default avatarPeter Huewe <peterhuewe@gmx.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent d662b8eb
...@@ -819,15 +819,15 @@ unifi_write(struct file *filp, const char *p, size_t len, loff_t *poff) ...@@ -819,15 +819,15 @@ unifi_write(struct file *filp, const char *p, size_t len, loff_t *poff)
unifi_trace(priv, UDBG2, "unifi_write: signal 0x%.4X len:%d\n", unifi_trace(priv, UDBG2, "unifi_write: signal 0x%.4X len:%d\n",
sig_id, signal_size); sig_id, signal_size);
/* Allocate a buffer for the signal */ /* Allocate a buffer for the signal */
signal_buf = kmalloc(signal_size, GFP_KERNEL); signal_buf = kmemdup(bulkdata.d[0].os_data_ptr, signal_size,
GFP_KERNEL);
if (!signal_buf) { if (!signal_buf) {
unifi_net_data_free(priv, &bulkdata.d[0]); unifi_net_data_free(priv, &bulkdata.d[0]);
return -ENOMEM; return -ENOMEM;
} }
/* Get the signal from the os_data_ptr */ /* Get the signal from the os_data_ptr */
memcpy(signal_buf, bulkdata.d[0].os_data_ptr, signal_size);
signal_buf[5] = (pcli->sender_id >> 8) & 0xff; signal_buf[5] = (pcli->sender_id >> 8) & 0xff;
if (signal_size < len) { if (signal_size < len) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment