Commit 2665eb8e authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Greg Kroah-Hartman

usb: misc: usb251xb: drop of_match_ptr for ID table

The driver will match mostly by DT table (even thought there is regular
ID table) so there is little benefit in of_match_ptr (this also allows
ACPI matching via PRP0001, even though it might not be relevant here).

  drivers/usb/misc/usb251xb.c:223:35: error: ‘usb2517i_data’ defined but not used [-Werror=unused-const-variable=]
  drivers/usb/misc/usb251xb.c:215:35: error: ‘usb2517_data’ defined but not used [-Werror=unused-const-variable=]
  drivers/usb/misc/usb251xb.c:207:35: error: ‘usb2514bi_data’ defined but not used [-Werror=unused-const-variable=]
Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Acked-by: default avatarRichard Leitner <richard.leitner@skidata.com>
Link: https://lore.kernel.org/r/20230311173624.263189-7-krzysztof.kozlowski@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f80391dd
...@@ -377,7 +377,6 @@ static int usb251xb_connect(struct usb251xb *hub) ...@@ -377,7 +377,6 @@ static int usb251xb_connect(struct usb251xb *hub)
return err; return err;
} }
#ifdef CONFIG_OF
static void usb251xb_get_ports_field(struct usb251xb *hub, static void usb251xb_get_ports_field(struct usb251xb *hub,
const char *prop_name, u8 port_cnt, const char *prop_name, u8 port_cnt,
bool ds_only, u8 *fld) bool ds_only, u8 *fld)
...@@ -623,13 +622,6 @@ static const struct of_device_id usb251xb_of_match[] = { ...@@ -623,13 +622,6 @@ static const struct of_device_id usb251xb_of_match[] = {
} }
}; };
MODULE_DEVICE_TABLE(of, usb251xb_of_match); MODULE_DEVICE_TABLE(of, usb251xb_of_match);
#else /* CONFIG_OF */
static int usb251xb_get_ofdata(struct usb251xb *hub,
const struct usb251xb_data *data)
{
return 0;
}
#endif /* CONFIG_OF */
static void usb251xb_regulator_disable_action(void *data) static void usb251xb_regulator_disable_action(void *data)
{ {
...@@ -751,7 +743,7 @@ MODULE_DEVICE_TABLE(i2c, usb251xb_id); ...@@ -751,7 +743,7 @@ MODULE_DEVICE_TABLE(i2c, usb251xb_id);
static struct i2c_driver usb251xb_i2c_driver = { static struct i2c_driver usb251xb_i2c_driver = {
.driver = { .driver = {
.name = DRIVER_NAME, .name = DRIVER_NAME,
.of_match_table = of_match_ptr(usb251xb_of_match), .of_match_table = usb251xb_of_match,
.pm = &usb251xb_pm_ops, .pm = &usb251xb_pm_ops,
}, },
.probe_new = usb251xb_i2c_probe, .probe_new = usb251xb_i2c_probe,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment