Commit 26a4591b authored by Markus Elfring's avatar Markus Elfring Committed by Luben Tuikov

drm/sched: Return an error code only as a constant in drm_sched_init()

Return an error code without storing it in an intermediate variable.
Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Link: https://patchwork.freedesktop.org/patch/msgid/85f8004e-f0c9-42d9-8c59-30f1b4e0b89e@web.deReviewed-by: default avatarLuben Tuikov <ltuikov89@gmail.com>
Signed-off-by: default avatarLuben Tuikov <ltuikov89@gmail.com>
parent 3bb45618
...@@ -1249,7 +1249,7 @@ int drm_sched_init(struct drm_gpu_scheduler *sched, ...@@ -1249,7 +1249,7 @@ int drm_sched_init(struct drm_gpu_scheduler *sched,
long timeout, struct workqueue_struct *timeout_wq, long timeout, struct workqueue_struct *timeout_wq,
atomic_t *score, const char *name, struct device *dev) atomic_t *score, const char *name, struct device *dev)
{ {
int i, ret; int i;
sched->ops = ops; sched->ops = ops;
sched->credit_limit = credit_limit; sched->credit_limit = credit_limit;
...@@ -1285,7 +1285,7 @@ int drm_sched_init(struct drm_gpu_scheduler *sched, ...@@ -1285,7 +1285,7 @@ int drm_sched_init(struct drm_gpu_scheduler *sched,
sched->own_submit_wq = true; sched->own_submit_wq = true;
} }
ret = -ENOMEM;
sched->sched_rq = kmalloc_array(num_rqs, sizeof(*sched->sched_rq), sched->sched_rq = kmalloc_array(num_rqs, sizeof(*sched->sched_rq),
GFP_KERNEL | __GFP_ZERO); GFP_KERNEL | __GFP_ZERO);
if (!sched->sched_rq) if (!sched->sched_rq)
...@@ -1321,7 +1321,7 @@ int drm_sched_init(struct drm_gpu_scheduler *sched, ...@@ -1321,7 +1321,7 @@ int drm_sched_init(struct drm_gpu_scheduler *sched,
if (sched->own_submit_wq) if (sched->own_submit_wq)
destroy_workqueue(sched->submit_wq); destroy_workqueue(sched->submit_wq);
drm_err(sched, "%s: Failed to setup GPU scheduler--out of memory\n", __func__); drm_err(sched, "%s: Failed to setup GPU scheduler--out of memory\n", __func__);
return ret; return -ENOMEM;
} }
EXPORT_SYMBOL(drm_sched_init); EXPORT_SYMBOL(drm_sched_init);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment