Commit 26f9bcad authored by Michal Suchanek's avatar Michal Suchanek Committed by Brian Norris

mtd: spi-nor: add read loop

mtdblock and ubi do not handle the situation when read returns less data
than requested. Loop in spi-nor until buffer is filled or an error is
returned.
Signed-off-by: default avatarMichal Suchanek <hramrach@gmail.com>
Signed-off-by: default avatarBrian Norris <computersforpeace@gmail.com>
Tested-by Cyrille Pitchen <cyrille.pitchen@atmel.com>
Acked-by: default avatarMichal Suchanek <hramrach@gmail.com>
Tested-by: default avatarMichal Suchanek <hramrach@gmail.com>
parent e5d05cbd
...@@ -1031,14 +1031,27 @@ static int spi_nor_read(struct mtd_info *mtd, loff_t from, size_t len, ...@@ -1031,14 +1031,27 @@ static int spi_nor_read(struct mtd_info *mtd, loff_t from, size_t len,
if (ret) if (ret)
return ret; return ret;
ret = nor->read(nor, from, len, buf); while (len) {
ret = nor->read(nor, from, len, buf);
if (ret == 0) {
/* We shouldn't see 0-length reads */
ret = -EIO;
goto read_err;
}
if (ret < 0)
goto read_err;
spi_nor_unlock_and_unprep(nor, SPI_NOR_OPS_READ); WARN_ON(ret > len);
if (ret < 0) *retlen += ret;
return ret; buf += ret;
from += ret;
len -= ret;
}
ret = 0;
*retlen += ret; read_err:
return 0; spi_nor_unlock_and_unprep(nor, SPI_NOR_OPS_READ);
return ret;
} }
static int sst_write(struct mtd_info *mtd, loff_t to, size_t len, static int sst_write(struct mtd_info *mtd, loff_t to, size_t len,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment