Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
L
linux
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
linux
Commits
2744c171
Commit
2744c171
authored
Sep 26, 2012
by
Al Viro
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
ceph: don't abuse d_delete() on failure exits
Signed-off-by:
Al Viro
<
viro@zeniv.linux.org.uk
>
parent
3a8ca1b6
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
2 additions
and
2 deletions
+2
-2
fs/ceph/inode.c
fs/ceph/inode.c
+2
-2
No files found.
fs/ceph/inode.c
View file @
2744c171
...
@@ -1104,7 +1104,7 @@ int ceph_fill_trace(struct super_block *sb, struct ceph_mds_request *req,
...
@@ -1104,7 +1104,7 @@ int ceph_fill_trace(struct super_block *sb, struct ceph_mds_request *req,
pr_err
(
"fill_trace bad get_inode "
pr_err
(
"fill_trace bad get_inode "
"%llx.%llx
\n
"
,
vino
.
ino
,
vino
.
snap
);
"%llx.%llx
\n
"
,
vino
.
ino
,
vino
.
snap
);
err
=
PTR_ERR
(
in
);
err
=
PTR_ERR
(
in
);
d_d
elete
(
dn
);
d_d
rop
(
dn
);
goto
done
;
goto
done
;
}
}
dn
=
splice_dentry
(
dn
,
in
,
&
have_lease
,
true
);
dn
=
splice_dentry
(
dn
,
in
,
&
have_lease
,
true
);
...
@@ -1277,7 +1277,7 @@ int ceph_readdir_prepopulate(struct ceph_mds_request *req,
...
@@ -1277,7 +1277,7 @@ int ceph_readdir_prepopulate(struct ceph_mds_request *req,
in
=
ceph_get_inode
(
parent
->
d_sb
,
vino
);
in
=
ceph_get_inode
(
parent
->
d_sb
,
vino
);
if
(
IS_ERR
(
in
))
{
if
(
IS_ERR
(
in
))
{
dout
(
"new_inode badness
\n
"
);
dout
(
"new_inode badness
\n
"
);
d_d
elete
(
dn
);
d_d
rop
(
dn
);
dput
(
dn
);
dput
(
dn
);
err
=
PTR_ERR
(
in
);
err
=
PTR_ERR
(
in
);
goto
out
;
goto
out
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment