Commit 27646b2e authored by Benjamin Gray's avatar Benjamin Gray Committed by Michael Ellerman

powerpc/watchpoints: Annotate atomic context in more places

It can be easy to miss that the notifier mechanism invokes the callbacks
in an atomic context, so add some comments to that effect on the two
handlers we register here.
Signed-off-by: default avatarBenjamin Gray <bgray@linux.ibm.com>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Link: https://msgid.link/20230829063457.54157-4-bgray@linux.ibm.com
parent 3241f260
...@@ -368,6 +368,11 @@ static void handle_p10dd1_spurious_exception(struct perf_event **bp, ...@@ -368,6 +368,11 @@ static void handle_p10dd1_spurious_exception(struct perf_event **bp,
} }
} }
/*
* Handle a DABR or DAWR exception.
*
* Called in atomic context.
*/
int hw_breakpoint_handler(struct die_args *args) int hw_breakpoint_handler(struct die_args *args)
{ {
bool err = false; bool err = false;
...@@ -495,6 +500,8 @@ NOKPROBE_SYMBOL(hw_breakpoint_handler); ...@@ -495,6 +500,8 @@ NOKPROBE_SYMBOL(hw_breakpoint_handler);
/* /*
* Handle single-step exceptions following a DABR hit. * Handle single-step exceptions following a DABR hit.
*
* Called in atomic context.
*/ */
static int single_step_dabr_instruction(struct die_args *args) static int single_step_dabr_instruction(struct die_args *args)
{ {
...@@ -546,6 +553,8 @@ NOKPROBE_SYMBOL(single_step_dabr_instruction); ...@@ -546,6 +553,8 @@ NOKPROBE_SYMBOL(single_step_dabr_instruction);
/* /*
* Handle debug exception notifications. * Handle debug exception notifications.
*
* Called in atomic context.
*/ */
int hw_breakpoint_exceptions_notify( int hw_breakpoint_exceptions_notify(
struct notifier_block *unused, unsigned long val, void *data) struct notifier_block *unused, unsigned long val, void *data)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment