Commit 281fda27 authored by Richard Weinberger's avatar Richard Weinberger

UBI: Validate data_size

Make sure that data_size is less than LEB size.
Otherwise a handcrafted UBI image is able to trigger
an out of bounds memory access in ubi_compare_lebs().

Cc: stable@vger.kernel.org
Signed-off-by: default avatarRichard Weinberger <richard@nod.at>
Reviewed-by: default avatarDavid Gstir <david@sigma-star.at>
parent cf6f54e3
...@@ -926,6 +926,11 @@ static int validate_vid_hdr(const struct ubi_device *ubi, ...@@ -926,6 +926,11 @@ static int validate_vid_hdr(const struct ubi_device *ubi,
goto bad; goto bad;
} }
if (data_size > ubi->leb_size) {
ubi_err(ubi, "bad data_size");
goto bad;
}
if (vol_type == UBI_VID_STATIC) { if (vol_type == UBI_VID_STATIC) {
/* /*
* Although from high-level point of view static volumes may * Although from high-level point of view static volumes may
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment