Commit 284ae44a authored by Geliang Tang's avatar Geliang Tang Committed by Greg Kroah-Hartman

pstore: drop file opened reference count

commit 52d210d9 upstream.

In ee1d2674 ("pstore: add pstore unregister") I added:
	.owner = THIS_MODULE,
in both pstore_fs_type and pstore_file_operations to increase a reference
count when pstore filesystem is mounted and pstore file is opened.

But, it's repetitive. There is no need to increase the opened reference
count. We only need to increase the mounted reference count. When a file
is opened, the filesystem can't be unmounted. Hence the pstore module
can't be unloaded either.

So I drop the opened reference count in this patch.

Fixes: ee1d2674 ("pstore: add pstore unregister")
Signed-off-by: default avatarGeliang Tang <geliangtang@163.com>
Signed-off-by: default avatarKees Cook <keescook@chromium.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 4042db31
...@@ -178,7 +178,6 @@ static loff_t pstore_file_llseek(struct file *file, loff_t off, int whence) ...@@ -178,7 +178,6 @@ static loff_t pstore_file_llseek(struct file *file, loff_t off, int whence)
} }
static const struct file_operations pstore_file_operations = { static const struct file_operations pstore_file_operations = {
.owner = THIS_MODULE,
.open = pstore_file_open, .open = pstore_file_open,
.read = pstore_file_read, .read = pstore_file_read,
.llseek = pstore_file_llseek, .llseek = pstore_file_llseek,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment