Commit 28b00875 authored by Joy Chakraborty's avatar Joy Chakraborty Committed by Greg Kroah-Hartman

nvmem: rmem: Fix return value of rmem_read()

reg_read() callback registered with nvmem core expects 0 on success and
a negative value on error but rmem_read() returns the number of bytes
read which is treated as an error at the nvmem core.

This does not break when rmem is accessed using sysfs via
bin_attr_nvmem_read()/write() but causes an error when accessed from
places like nvmem_access_with_keepouts(), etc.

Change to return 0 on success and error in case
memory_read_from_buffer() returns an error or -EIO if bytes read do not
match what was requested.

Fixes: 5a3fa75a ("nvmem: Add driver to expose reserved memory as nvmem")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarJoy Chakraborty <joychakr@google.com>
Reviewed-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: default avatarSrinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20240628113704.13742-2-srinivas.kandagatla@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent a6a0f04e
...@@ -46,7 +46,10 @@ static int rmem_read(void *context, unsigned int offset, ...@@ -46,7 +46,10 @@ static int rmem_read(void *context, unsigned int offset,
memunmap(addr); memunmap(addr);
if (count < 0)
return count; return count;
return count == bytes ? 0 : -EIO;
} }
static int rmem_probe(struct platform_device *pdev) static int rmem_probe(struct platform_device *pdev)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment