perf evlist: Use the right prefix for 'struct evlist' sample parsing methods

perf_evlist__ is for 'struct perf_evlist' methods, in tools/lib/perf/,
go on completing this split.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Ian Rogers <irogers@google.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 08c83997
...@@ -764,7 +764,7 @@ static s64 perf_kvm__mmap_read_idx(struct perf_kvm_stat *kvm, int idx, ...@@ -764,7 +764,7 @@ static s64 perf_kvm__mmap_read_idx(struct perf_kvm_stat *kvm, int idx,
return (err == -EAGAIN) ? 0 : -1; return (err == -EAGAIN) ? 0 : -1;
while ((event = perf_mmap__read_event(&md->core)) != NULL) { while ((event = perf_mmap__read_event(&md->core)) != NULL) {
err = perf_evlist__parse_sample_timestamp(evlist, event, &timestamp); err = evlist__parse_sample_timestamp(evlist, event, &timestamp);
if (err) { if (err) {
perf_mmap__consume(&md->core); perf_mmap__consume(&md->core);
pr_err("Failed to parse sample\n"); pr_err("Failed to parse sample\n");
......
...@@ -890,7 +890,7 @@ static void perf_top__mmap_read_idx(struct perf_top *top, int idx) ...@@ -890,7 +890,7 @@ static void perf_top__mmap_read_idx(struct perf_top *top, int idx)
while ((event = perf_mmap__read_event(&md->core)) != NULL) { while ((event = perf_mmap__read_event(&md->core)) != NULL) {
int ret; int ret;
ret = perf_evlist__parse_sample_timestamp(evlist, event, &last_timestamp); ret = evlist__parse_sample_timestamp(evlist, event, &last_timestamp);
if (ret && ret != -1) if (ret && ret != -1)
break; break;
...@@ -1153,7 +1153,7 @@ static int deliver_event(struct ordered_events *qe, ...@@ -1153,7 +1153,7 @@ static int deliver_event(struct ordered_events *qe,
return 0; return 0;
} }
ret = perf_evlist__parse_sample(evlist, event, &sample); ret = evlist__parse_sample(evlist, event, &sample);
if (ret) { if (ret) {
pr_err("Can't parse sample, err = %d\n", ret); pr_err("Can't parse sample, err = %d\n", ret);
goto next_event; goto next_event;
......
...@@ -3700,9 +3700,8 @@ static int __trace__deliver_event(struct trace *trace, union perf_event *event) ...@@ -3700,9 +3700,8 @@ static int __trace__deliver_event(struct trace *trace, union perf_event *event)
{ {
struct evlist *evlist = trace->evlist; struct evlist *evlist = trace->evlist;
struct perf_sample sample; struct perf_sample sample;
int err; int err = evlist__parse_sample(evlist, event, &sample);
err = perf_evlist__parse_sample(evlist, event, &sample);
if (err) if (err)
fprintf(trace->output, "Can't parse sample, err = %d, skipping...\n", err); fprintf(trace->output, "Can't parse sample, err = %d, skipping...\n", err);
else else
...@@ -3735,7 +3734,7 @@ static int trace__deliver_event(struct trace *trace, union perf_event *event) ...@@ -3735,7 +3734,7 @@ static int trace__deliver_event(struct trace *trace, union perf_event *event)
if (!trace->sort_events) if (!trace->sort_events)
return __trace__deliver_event(trace, event); return __trace__deliver_event(trace, event);
err = perf_evlist__parse_sample_timestamp(trace->evlist, event, &trace->oe.last); err = evlist__parse_sample_timestamp(trace->evlist, event, &trace->oe.last);
if (err && err != -1) if (err && err != -1)
return err; return err;
......
...@@ -378,8 +378,8 @@ static int process_sample_event(struct machine *machine, ...@@ -378,8 +378,8 @@ static int process_sample_event(struct machine *machine,
struct thread *thread; struct thread *thread;
int ret; int ret;
if (perf_evlist__parse_sample(evlist, event, &sample)) { if (evlist__parse_sample(evlist, event, &sample)) {
pr_debug("perf_evlist__parse_sample failed\n"); pr_debug("evlist__parse_sample failed\n");
return -1; return -1;
} }
......
...@@ -126,7 +126,7 @@ int test__basic_mmap(struct test *test __maybe_unused, int subtest __maybe_unuse ...@@ -126,7 +126,7 @@ int test__basic_mmap(struct test *test __maybe_unused, int subtest __maybe_unuse
goto out_delete_evlist; goto out_delete_evlist;
} }
err = perf_evlist__parse_sample(evlist, event, &sample); err = evlist__parse_sample(evlist, event, &sample);
if (err) { if (err) {
pr_err("Can't parse sample, err = %d\n", err); pr_err("Can't parse sample, err = %d\n", err);
goto out_delete_evlist; goto out_delete_evlist;
......
...@@ -27,8 +27,8 @@ static int process_event(struct evlist **pevlist, union perf_event *event) ...@@ -27,8 +27,8 @@ static int process_event(struct evlist **pevlist, union perf_event *event)
if (!*pevlist) if (!*pevlist)
return -1; return -1;
if (perf_evlist__parse_sample(*pevlist, event, &sample)) { if (evlist__parse_sample(*pevlist, event, &sample)) {
pr_debug("perf_evlist__parse_sample failed\n"); pr_debug("evlist__parse_sample failed\n");
return -1; return -1;
} }
......
...@@ -182,7 +182,7 @@ int test__PERF_RECORD(struct test *test __maybe_unused, int subtest __maybe_unus ...@@ -182,7 +182,7 @@ int test__PERF_RECORD(struct test *test __maybe_unused, int subtest __maybe_unus
if (type < PERF_RECORD_MAX) if (type < PERF_RECORD_MAX)
nr_events[type]++; nr_events[type]++;
err = perf_evlist__parse_sample(evlist, event, &sample); err = evlist__parse_sample(evlist, event, &sample);
if (err < 0) { if (err < 0) {
if (verbose > 0) if (verbose > 0)
perf_event__fprintf(event, NULL, stderr); perf_event__fprintf(event, NULL, stderr);
......
...@@ -109,7 +109,7 @@ static int __test__sw_clock_freq(enum perf_sw_ids clock_id) ...@@ -109,7 +109,7 @@ static int __test__sw_clock_freq(enum perf_sw_ids clock_id)
if (event->header.type != PERF_RECORD_SAMPLE) if (event->header.type != PERF_RECORD_SAMPLE)
goto next_event; goto next_event;
err = perf_evlist__parse_sample(evlist, event, &sample); err = evlist__parse_sample(evlist, event, &sample);
if (err < 0) { if (err < 0) {
pr_debug("Error during parse sample\n"); pr_debug("Error during parse sample\n");
goto out_delete_evlist; goto out_delete_evlist;
......
...@@ -128,8 +128,8 @@ static int process_sample_event(struct evlist *evlist, ...@@ -128,8 +128,8 @@ static int process_sample_event(struct evlist *evlist,
pid_t next_tid, prev_tid; pid_t next_tid, prev_tid;
int cpu, err; int cpu, err;
if (perf_evlist__parse_sample(evlist, event, &sample)) { if (evlist__parse_sample(evlist, event, &sample)) {
pr_debug("perf_evlist__parse_sample failed\n"); pr_debug("evlist__parse_sample failed\n");
return -1; return -1;
} }
...@@ -223,8 +223,8 @@ static int add_event(struct evlist *evlist, struct list_head *events, ...@@ -223,8 +223,8 @@ static int add_event(struct evlist *evlist, struct list_head *events,
node->event = event; node->event = event;
list_add(&node->list, events); list_add(&node->list, events);
if (perf_evlist__parse_sample(evlist, event, &sample)) { if (evlist__parse_sample(evlist, event, &sample)) {
pr_debug("perf_evlist__parse_sample failed\n"); pr_debug("evlist__parse_sample failed\n");
return -1; return -1;
} }
......
...@@ -1082,7 +1082,7 @@ static int auxtrace_queue_data_cb(struct perf_session *session, ...@@ -1082,7 +1082,7 @@ static int auxtrace_queue_data_cb(struct perf_session *session,
if (!qd->samples || event->header.type != PERF_RECORD_SAMPLE) if (!qd->samples || event->header.type != PERF_RECORD_SAMPLE)
return 0; return 0;
err = perf_evlist__parse_sample(session->evlist, event, &sample); err = evlist__parse_sample(session->evlist, event, &sample);
if (err) if (err)
return err; return err;
......
...@@ -1447,8 +1447,7 @@ int evlist__start_workload(struct evlist *evlist) ...@@ -1447,8 +1447,7 @@ int evlist__start_workload(struct evlist *evlist)
return 0; return 0;
} }
int perf_evlist__parse_sample(struct evlist *evlist, union perf_event *event, int evlist__parse_sample(struct evlist *evlist, union perf_event *event, struct perf_sample *sample)
struct perf_sample *sample)
{ {
struct evsel *evsel = perf_evlist__event2evsel(evlist, event); struct evsel *evsel = perf_evlist__event2evsel(evlist, event);
...@@ -1457,9 +1456,7 @@ int perf_evlist__parse_sample(struct evlist *evlist, union perf_event *event, ...@@ -1457,9 +1456,7 @@ int perf_evlist__parse_sample(struct evlist *evlist, union perf_event *event,
return evsel__parse_sample(evsel, event, sample); return evsel__parse_sample(evsel, event, sample);
} }
int perf_evlist__parse_sample_timestamp(struct evlist *evlist, int evlist__parse_sample_timestamp(struct evlist *evlist, union perf_event *event, u64 *timestamp)
union perf_event *event,
u64 *timestamp)
{ {
struct evsel *evsel = perf_evlist__event2evsel(evlist, event); struct evsel *evsel = perf_evlist__event2evsel(evlist, event);
......
...@@ -224,12 +224,8 @@ u64 evlist__combined_branch_type(struct evlist *evlist); ...@@ -224,12 +224,8 @@ u64 evlist__combined_branch_type(struct evlist *evlist);
bool evlist__sample_id_all(struct evlist *evlist); bool evlist__sample_id_all(struct evlist *evlist);
u16 perf_evlist__id_hdr_size(struct evlist *evlist); u16 perf_evlist__id_hdr_size(struct evlist *evlist);
int perf_evlist__parse_sample(struct evlist *evlist, union perf_event *event, int evlist__parse_sample(struct evlist *evlist, union perf_event *event, struct perf_sample *sample);
struct perf_sample *sample); int evlist__parse_sample_timestamp(struct evlist *evlist, union perf_event *event, u64 *timestamp);
int perf_evlist__parse_sample_timestamp(struct evlist *evlist,
union perf_event *event,
u64 *timestamp);
bool evlist__valid_sample_type(struct evlist *evlist); bool evlist__valid_sample_type(struct evlist *evlist);
bool evlist__valid_sample_id_all(struct evlist *evlist); bool evlist__valid_sample_id_all(struct evlist *evlist);
......
...@@ -96,9 +96,9 @@ ...@@ -96,9 +96,9 @@
* | than PERF_RECORD_USER_TYPE_START) are handled by * | than PERF_RECORD_USER_TYPE_START) are handled by
* | perf_session__process_user_event(see below) * | perf_session__process_user_event(see below)
* | - Those generated by the kernel are handled by * | - Those generated by the kernel are handled by
* | perf_evlist__parse_sample_timestamp() * | evlist__parse_sample_timestamp()
* | * |
* perf_evlist__parse_sample_timestamp() * evlist__parse_sample_timestamp()
* | Extract time stamp from sample data. * | Extract time stamp from sample data.
* | * |
* perf_session__queue_event() * perf_session__queue_event()
......
...@@ -1523,9 +1523,8 @@ static int perf_session__deliver_event(struct perf_session *session, ...@@ -1523,9 +1523,8 @@ static int perf_session__deliver_event(struct perf_session *session,
u64 file_offset) u64 file_offset)
{ {
struct perf_sample sample; struct perf_sample sample;
int ret; int ret = evlist__parse_sample(session->evlist, event, &sample);
ret = perf_evlist__parse_sample(session->evlist, event, &sample);
if (ret) { if (ret) {
pr_err("Can't parse sample, err = %d\n", ret); pr_err("Can't parse sample, err = %d\n", ret);
return ret; return ret;
...@@ -1697,7 +1696,7 @@ int perf_session__peek_event(struct perf_session *session, off_t file_offset, ...@@ -1697,7 +1696,7 @@ int perf_session__peek_event(struct perf_session *session, off_t file_offset,
out_parse_sample: out_parse_sample:
if (sample && event->header.type < PERF_RECORD_USER_TYPE_START && if (sample && event->header.type < PERF_RECORD_USER_TYPE_START &&
perf_evlist__parse_sample(session->evlist, event, sample)) evlist__parse_sample(session->evlist, event, sample))
return -1; return -1;
*event_ptr = event; *event_ptr = event;
...@@ -1754,7 +1753,7 @@ static s64 perf_session__process_event(struct perf_session *session, ...@@ -1754,7 +1753,7 @@ static s64 perf_session__process_event(struct perf_session *session,
if (tool->ordered_events) { if (tool->ordered_events) {
u64 timestamp = -1ULL; u64 timestamp = -1ULL;
ret = perf_evlist__parse_sample_timestamp(evlist, event, &timestamp); ret = evlist__parse_sample_timestamp(evlist, event, &timestamp);
if (ret && ret != -1) if (ret && ret != -1)
return ret; return ret;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment