Commit 2a7d5559 authored by Shaohua Li's avatar Shaohua Li Committed by Jens Axboe

block: stack unplug

MD raid1 prepares to dispatch request in unplug callback. If make_request in
low level queue also uses unplug callback to dispatch request, the low level
queue's unplug callback will not be called. Recheck the callback list helps
this case.
Signed-off-by: default avatarShaohua Li <shli@fusionio.com>
Signed-off-by: default avatarNeilBrown <neilb@suse.de>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 9cbb1750
...@@ -2913,9 +2913,7 @@ static void flush_plug_callbacks(struct blk_plug *plug) ...@@ -2913,9 +2913,7 @@ static void flush_plug_callbacks(struct blk_plug *plug)
{ {
LIST_HEAD(callbacks); LIST_HEAD(callbacks);
if (list_empty(&plug->cb_list)) while (!list_empty(&plug->cb_list)) {
return;
list_splice_init(&plug->cb_list, &callbacks); list_splice_init(&plug->cb_list, &callbacks);
while (!list_empty(&callbacks)) { while (!list_empty(&callbacks)) {
...@@ -2925,6 +2923,7 @@ static void flush_plug_callbacks(struct blk_plug *plug) ...@@ -2925,6 +2923,7 @@ static void flush_plug_callbacks(struct blk_plug *plug)
list_del(&cb->list); list_del(&cb->list);
cb->callback(cb); cb->callback(cb);
} }
}
} }
struct blk_plug_cb *blk_check_plugged(blk_plug_cb_fn unplug, void *data, struct blk_plug_cb *blk_check_plugged(blk_plug_cb_fn unplug, void *data,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment