Commit 2bc32db5 authored by Dawei Li's avatar Dawei Li Committed by Thomas Gleixner

irqchip/loongson-eiointc: Avoid explicit cpumask allocation on stack

In general it's preferable to avoid placing cpumasks on the stack, as
for large values of NR_CPUS these can consume significant amounts of
stack space and make stack overflows more likely.

Use cpumask_first_and_and() to avoid the need for a temporary cpumask on
the stack.
Signed-off-by: default avatarDawei Li <dawei.li@shingroup.cn>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Reviewed-by: default avatarYury Norov <yury.norov@gmail.com>
Link: https://lore.kernel.org/r/20240416085454.3547175-5-dawei.li@shingroup.cn
parent fcb8af4c
...@@ -93,19 +93,15 @@ static int eiointc_set_irq_affinity(struct irq_data *d, const struct cpumask *af ...@@ -93,19 +93,15 @@ static int eiointc_set_irq_affinity(struct irq_data *d, const struct cpumask *af
unsigned int cpu; unsigned int cpu;
unsigned long flags; unsigned long flags;
uint32_t vector, regaddr; uint32_t vector, regaddr;
struct cpumask intersect_affinity;
struct eiointc_priv *priv = d->domain->host_data; struct eiointc_priv *priv = d->domain->host_data;
raw_spin_lock_irqsave(&affinity_lock, flags); raw_spin_lock_irqsave(&affinity_lock, flags);
cpumask_and(&intersect_affinity, affinity, cpu_online_mask); cpu = cpumask_first_and_and(&priv->cpuspan_map, affinity, cpu_online_mask);
cpumask_and(&intersect_affinity, &intersect_affinity, &priv->cpuspan_map); if (cpu >= nr_cpu_ids) {
if (cpumask_empty(&intersect_affinity)) {
raw_spin_unlock_irqrestore(&affinity_lock, flags); raw_spin_unlock_irqrestore(&affinity_lock, flags);
return -EINVAL; return -EINVAL;
} }
cpu = cpumask_first(&intersect_affinity);
vector = d->hwirq; vector = d->hwirq;
regaddr = EIOINTC_REG_ENABLE + ((vector >> 5) << 2); regaddr = EIOINTC_REG_ENABLE + ((vector >> 5) << 2);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment