Commit 2bc62b67 authored by H Hartley Sweeten's avatar H Hartley Sweeten Committed by Greg Kroah-Hartman

staging: comedi: refactor pcl726 driver to remove forward declarations

Move the module_init/module_exit routines and the associated
struct comedi_driver and other variables to the end of the source.
This is more typical of how other drivers are written and removes
the need for the forward declarations.
Signed-off-by: default avatarH Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f21a38c4
...@@ -111,10 +111,6 @@ static const struct comedi_lrange *const rangelist_728[] = { ...@@ -111,10 +111,6 @@ static const struct comedi_lrange *const rangelist_728[] = {
&range_4_20mA, &range_0_20mA &range_4_20mA, &range_0_20mA
}; };
static int pcl726_attach(struct comedi_device *dev,
struct comedi_devconfig *it);
static int pcl726_detach(struct comedi_device *dev);
struct pcl726_board { struct pcl726_board {
const char *name; /* driver name */ const char *name; /* driver name */
...@@ -151,29 +147,6 @@ static const struct pcl726_board boardtypes[] = { ...@@ -151,29 +147,6 @@ static const struct pcl726_board boardtypes[] = {
#define this_board ((const struct pcl726_board *)dev->board_ptr) #define this_board ((const struct pcl726_board *)dev->board_ptr)
static struct comedi_driver driver_pcl726 = {
.driver_name = "pcl726",
.module = THIS_MODULE,
.attach = pcl726_attach,
.detach = pcl726_detach,
.board_name = &boardtypes[0].name,
.num_names = ARRAY_SIZE(boardtypes),
.offset = sizeof(struct pcl726_board),
};
static int __init driver_pcl726_init_module(void)
{
return comedi_driver_register(&driver_pcl726);
}
static void __exit driver_pcl726_cleanup_module(void)
{
comedi_driver_unregister(&driver_pcl726);
}
module_init(driver_pcl726_init_module);
module_exit(driver_pcl726_cleanup_module);
struct pcl726_private { struct pcl726_private {
int bipolar[12]; int bipolar[12];
...@@ -392,6 +365,28 @@ static int pcl726_detach(struct comedi_device *dev) ...@@ -392,6 +365,28 @@ static int pcl726_detach(struct comedi_device *dev)
return 0; return 0;
} }
static struct comedi_driver driver_pcl726 = {
.driver_name = "pcl726",
.module = THIS_MODULE,
.attach = pcl726_attach,
.detach = pcl726_detach,
.board_name = &boardtypes[0].name,
.num_names = ARRAY_SIZE(boardtypes),
.offset = sizeof(struct pcl726_board),
};
static int __init driver_pcl726_init_module(void)
{
return comedi_driver_register(&driver_pcl726);
}
module_init(driver_pcl726_init_module);
static void __exit driver_pcl726_cleanup_module(void)
{
comedi_driver_unregister(&driver_pcl726);
}
module_exit(driver_pcl726_cleanup_module);
MODULE_AUTHOR("Comedi http://www.comedi.org"); MODULE_AUTHOR("Comedi http://www.comedi.org");
MODULE_DESCRIPTION("Comedi low-level driver"); MODULE_DESCRIPTION("Comedi low-level driver");
MODULE_LICENSE("GPL"); MODULE_LICENSE("GPL");
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment