Commit 2be0bc75 authored by Leo Yan's avatar Leo Yan Committed by Arnaldo Carvalho de Melo

perf c2c: Rename dimension from 'percent_hitm' to 'percent_costly_snoop'

Use more general naming for the main sort dimension, this can allow us
not to sort only on HITM snoop type, so it can be extended to support
other costly snooping operations.  So rename the dimension to the prefix
'percent_costly_".
Reviewed-by: default avatarAli Saidi <alisaidi@amazon.com>
Signed-off-by: default avatarLeo Yan <leo.yan@linaro.org>
Tested-by: default avatarAli Saidi <alisaidi@amazon.com>
Acked-by: default avatarIan Rogers <irogers@google.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: German Gomez <german.gomez@arm.com>
Cc: Gustavo A. R. Silva <gustavoars@kernel.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: James Clark <james.clark@arm.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: John Garry <john.garry@huawei.com>
Cc: Kajol Jain <kjain@linux.ibm.com>
Cc: Like Xu <likexu@tencent.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Mike Leach <mike.leach@linaro.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Timothy Hayes <timothy.hayes@arm.com>
Cc: Will Deacon <will@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org
Link: https://lore.kernel.org/r/20220811062451.435810-11-leo.yan@linaro.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent c82ccc3a
...@@ -798,7 +798,7 @@ percent_color(struct perf_hpp_fmt *fmt, struct perf_hpp *hpp, ...@@ -798,7 +798,7 @@ percent_color(struct perf_hpp_fmt *fmt, struct perf_hpp *hpp,
return hpp_color_scnprintf(hpp, "%*.2f%%", width - 1, per); return hpp_color_scnprintf(hpp, "%*.2f%%", width - 1, per);
} }
static double percent_hitm(struct c2c_hist_entry *c2c_he) static double percent_costly_snoop(struct c2c_hist_entry *c2c_he)
{ {
struct c2c_hists *hists; struct c2c_hists *hists;
struct c2c_stats *stats; struct c2c_stats *stats;
...@@ -838,8 +838,8 @@ static double percent_hitm(struct c2c_hist_entry *c2c_he) ...@@ -838,8 +838,8 @@ static double percent_hitm(struct c2c_hist_entry *c2c_he)
}) })
static int static int
percent_hitm_entry(struct perf_hpp_fmt *fmt, struct perf_hpp *hpp, percent_costly_snoop_entry(struct perf_hpp_fmt *fmt, struct perf_hpp *hpp,
struct hist_entry *he) struct hist_entry *he)
{ {
struct c2c_hist_entry *c2c_he; struct c2c_hist_entry *c2c_he;
int width = c2c_width(fmt, hpp, he->hists); int width = c2c_width(fmt, hpp, he->hists);
...@@ -847,20 +847,20 @@ percent_hitm_entry(struct perf_hpp_fmt *fmt, struct perf_hpp *hpp, ...@@ -847,20 +847,20 @@ percent_hitm_entry(struct perf_hpp_fmt *fmt, struct perf_hpp *hpp,
double per; double per;
c2c_he = container_of(he, struct c2c_hist_entry, he); c2c_he = container_of(he, struct c2c_hist_entry, he);
per = percent_hitm(c2c_he); per = percent_costly_snoop(c2c_he);
return scnprintf(hpp->buf, hpp->size, "%*s", width, PERC_STR(buf, per)); return scnprintf(hpp->buf, hpp->size, "%*s", width, PERC_STR(buf, per));
} }
static int static int
percent_hitm_color(struct perf_hpp_fmt *fmt, struct perf_hpp *hpp, percent_costly_snoop_color(struct perf_hpp_fmt *fmt, struct perf_hpp *hpp,
struct hist_entry *he) struct hist_entry *he)
{ {
return percent_color(fmt, hpp, he, percent_hitm); return percent_color(fmt, hpp, he, percent_costly_snoop);
} }
static int64_t static int64_t
percent_hitm_cmp(struct perf_hpp_fmt *fmt __maybe_unused, percent_costly_snoop_cmp(struct perf_hpp_fmt *fmt __maybe_unused,
struct hist_entry *left, struct hist_entry *right) struct hist_entry *left, struct hist_entry *right)
{ {
struct c2c_hist_entry *c2c_left; struct c2c_hist_entry *c2c_left;
struct c2c_hist_entry *c2c_right; struct c2c_hist_entry *c2c_right;
...@@ -870,8 +870,8 @@ percent_hitm_cmp(struct perf_hpp_fmt *fmt __maybe_unused, ...@@ -870,8 +870,8 @@ percent_hitm_cmp(struct perf_hpp_fmt *fmt __maybe_unused,
c2c_left = container_of(left, struct c2c_hist_entry, he); c2c_left = container_of(left, struct c2c_hist_entry, he);
c2c_right = container_of(right, struct c2c_hist_entry, he); c2c_right = container_of(right, struct c2c_hist_entry, he);
per_left = percent_hitm(c2c_left); per_left = percent_costly_snoop(c2c_left);
per_right = percent_hitm(c2c_right); per_right = percent_costly_snoop(c2c_right);
return per_left - per_right; return per_left - per_right;
} }
...@@ -1605,17 +1605,17 @@ static struct c2c_dimension dim_tot_loads = { ...@@ -1605,17 +1605,17 @@ static struct c2c_dimension dim_tot_loads = {
.width = 7, .width = 7,
}; };
static struct c2c_header percent_hitm_header[] = { static struct c2c_header percent_costly_snoop_header[] = {
[DISPLAY_LCL_HITM] = HEADER_BOTH("Lcl", "Hitm"), [DISPLAY_LCL_HITM] = HEADER_BOTH("Lcl", "Hitm"),
[DISPLAY_RMT_HITM] = HEADER_BOTH("Rmt", "Hitm"), [DISPLAY_RMT_HITM] = HEADER_BOTH("Rmt", "Hitm"),
[DISPLAY_TOT_HITM] = HEADER_BOTH("Tot", "Hitm"), [DISPLAY_TOT_HITM] = HEADER_BOTH("Tot", "Hitm"),
}; };
static struct c2c_dimension dim_percent_hitm = { static struct c2c_dimension dim_percent_costly_snoop = {
.name = "percent_hitm", .name = "percent_costly_snoop",
.cmp = percent_hitm_cmp, .cmp = percent_costly_snoop_cmp,
.entry = percent_hitm_entry, .entry = percent_costly_snoop_entry,
.color = percent_hitm_color, .color = percent_costly_snoop_color,
.width = 7, .width = 7,
}; };
...@@ -1844,7 +1844,7 @@ static struct c2c_dimension *dimensions[] = { ...@@ -1844,7 +1844,7 @@ static struct c2c_dimension *dimensions[] = {
&dim_ld_rmthit, &dim_ld_rmthit,
&dim_tot_recs, &dim_tot_recs,
&dim_tot_loads, &dim_tot_loads,
&dim_percent_hitm, &dim_percent_costly_snoop,
&dim_percent_rmt_hitm, &dim_percent_rmt_hitm,
&dim_percent_lcl_hitm, &dim_percent_lcl_hitm,
&dim_percent_rmt_peer, &dim_percent_rmt_peer,
...@@ -2748,7 +2748,7 @@ static int ui_quirks(void) ...@@ -2748,7 +2748,7 @@ static int ui_quirks(void)
nodestr = "CL"; nodestr = "CL";
} }
dim_percent_hitm.header = percent_hitm_header[c2c.display]; dim_percent_costly_snoop.header = percent_costly_snoop_header[c2c.display];
/* Fix the zero line for dcacheline column. */ /* Fix the zero line for dcacheline column. */
buf = fill_line("Cacheline", dim_dcacheline.width + buf = fill_line("Cacheline", dim_dcacheline.width +
...@@ -3076,7 +3076,7 @@ static int perf_c2c__report(int argc, const char **argv) ...@@ -3076,7 +3076,7 @@ static int perf_c2c__report(int argc, const char **argv)
"dcacheline," "dcacheline,"
"dcacheline_node," "dcacheline_node,"
"dcacheline_count," "dcacheline_count,"
"percent_hitm," "percent_costly_snoop,"
"tot_hitm,lcl_hitm,rmt_hitm," "tot_hitm,lcl_hitm,rmt_hitm,"
"tot_recs," "tot_recs,"
"tot_loads," "tot_loads,"
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment