Commit 2c163922 authored by Xi Huang's avatar Xi Huang Committed by Jakub Kicinski

net: dpaa: reduce number of synchronize_net() calls

In the function dpaa_napi_del(), we execute the netif_napi_del()
for each cpu, which is actually a high overhead operation
because each call to netif_napi_del() contains a synchronize_net(),
i.e. an RCU operation. In fact, it is only necessary to call
 __netif_napi_del and use synchronize_net() once outside of the loop.
This change is similar to commit 2543a600 ("gro_cells: reduce
number of synchronize_net() calls") and commit 5198d545 (" net:
remove napi_hash_del() from driver-facing API") 5198d545.
Signed-off-by: default avatarXi Huang <xuiagnh@gmail.com>
Reviewed-by: default avatarEric Dumazet <edumazet@google.com>
Link: https://patch.msgid.link/20240822072042.42750-1-xuiagnh@gmail.comSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 89683b45
......@@ -3156,8 +3156,9 @@ static void dpaa_napi_del(struct net_device *net_dev)
for_each_possible_cpu(cpu) {
percpu_priv = per_cpu_ptr(priv->percpu_priv, cpu);
netif_napi_del(&percpu_priv->np.napi);
__netif_napi_del(&percpu_priv->np.napi);
}
synchronize_net();
}
static inline void dpaa_bp_free_pf(const struct dpaa_bp *bp,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment