Commit 2c780f80 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Kamal Mostafa

power_supply: lp8788-charger: Fix leaked power supply on probe fail

commit a7117f81 upstream.

Driver forgot to unregister charger power supply if registering of
battery supply failed in probe(). In such case the memory associated
with power supply leaked.
Signed-off-by: default avatarKrzysztof Kozlowski <k.kozlowski@samsung.com>
Fixes: 98a27664 ("power_supply: Add new lp8788 charger driver")
Signed-off-by: default avatarSebastian Reichel <sre@kernel.org>
Signed-off-by: default avatarKamal Mostafa <kamal@canonical.com>
parent 8f0d9c4b
...@@ -417,8 +417,10 @@ static int lp8788_psy_register(struct platform_device *pdev, ...@@ -417,8 +417,10 @@ static int lp8788_psy_register(struct platform_device *pdev,
pchg->battery.num_properties = ARRAY_SIZE(lp8788_battery_prop); pchg->battery.num_properties = ARRAY_SIZE(lp8788_battery_prop);
pchg->battery.get_property = lp8788_battery_get_property; pchg->battery.get_property = lp8788_battery_get_property;
if (power_supply_register(&pdev->dev, &pchg->battery)) if (power_supply_register(&pdev->dev, &pchg->battery)) {
power_supply_unregister(&pchg->charger);
return -EPERM; return -EPERM;
}
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment