Commit 2c84b0aa authored by Justin Iurman's avatar Justin Iurman Committed by Jakub Kicinski

net: ipv6: rpl_iptunnel: Fix memory leak in rpl_input

Free the skb before returning from rpl_input when skb_cow_head() fails.
Use a "drop" label and goto instructions.

Fixes: a7a29f9c ("net: ipv6: add rpl sr tunnel")
Signed-off-by: default avatarJustin Iurman <justin.iurman@uliege.be>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20240911174557.11536-1-justin.iurman@uliege.beSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent b9c7ac4f
...@@ -263,10 +263,8 @@ static int rpl_input(struct sk_buff *skb) ...@@ -263,10 +263,8 @@ static int rpl_input(struct sk_buff *skb)
rlwt = rpl_lwt_lwtunnel(orig_dst->lwtstate); rlwt = rpl_lwt_lwtunnel(orig_dst->lwtstate);
err = rpl_do_srh(skb, rlwt); err = rpl_do_srh(skb, rlwt);
if (unlikely(err)) { if (unlikely(err))
kfree_skb(skb); goto drop;
return err;
}
local_bh_disable(); local_bh_disable();
dst = dst_cache_get(&rlwt->cache); dst = dst_cache_get(&rlwt->cache);
...@@ -286,9 +284,13 @@ static int rpl_input(struct sk_buff *skb) ...@@ -286,9 +284,13 @@ static int rpl_input(struct sk_buff *skb)
err = skb_cow_head(skb, LL_RESERVED_SPACE(dst->dev)); err = skb_cow_head(skb, LL_RESERVED_SPACE(dst->dev));
if (unlikely(err)) if (unlikely(err))
return err; goto drop;
return dst_input(skb); return dst_input(skb);
drop:
kfree_skb(skb);
return err;
} }
static int nla_put_rpl_srh(struct sk_buff *skb, int attrtype, static int nla_put_rpl_srh(struct sk_buff *skb, int attrtype,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment