Commit 2cf97338 authored by Steven Rostedt's avatar Steven Rostedt Committed by Steven Rostedt (Google)

ring-buffer: Fix refcount setting of boot mapped buffers

A ring buffer which has its buffered mapped at boot up to fixed memory
should not be freed. Other buffers can be. The ref counting setup was
wrong for both. It made the not mapped buffers ref count have zero, and the
boot mapped buffer a ref count of 1. But an normally allocated buffer
should be 1, where it can be removed.

Keep the ref count of a normal boot buffer with its setup ref count (do
not decrement it), and increment the fixed memory boot mapped buffer's ref
count.

Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Link: https://lore.kernel.org/20241011165224.33dd2624@gandalf.local.home
Fixes: e645535a ("tracing: Add option to use memmapped memory for trace boot instance")
Reviewed-by: default avatarMasami Hiramatsu (Google) <mhiramat@kernel.org>
Signed-off-by: default avatarSteven Rostedt (Google) <rostedt@goodmis.org>
parent 912da2c3
...@@ -10621,10 +10621,10 @@ __init static void enable_instances(void) ...@@ -10621,10 +10621,10 @@ __init static void enable_instances(void)
* cannot be deleted by user space, so keep the reference * cannot be deleted by user space, so keep the reference
* to it. * to it.
*/ */
if (start) if (start) {
tr->flags |= TRACE_ARRAY_FL_BOOT; tr->flags |= TRACE_ARRAY_FL_BOOT;
else tr->ref++;
trace_array_put(tr); }
while ((tok = strsep(&curr_str, ","))) { while ((tok = strsep(&curr_str, ","))) {
early_enable_events(tr, tok, true); early_enable_events(tr, tok, true);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment