Commit 2d325e54 authored by Raag Jadav's avatar Raag Jadav Committed by Andy Shevchenko

pinctrl: baytrail: fix debounce disable case

We don't need to update debounce pulse value in case debounce is to be
disabled. Break such a case where arg value is zero.

Fixes: 4cfff5b7 ("pinctrl: baytrail: consolidate common mask operation")
Reported-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/linux-gpio/d164d471-5432-4c3c-afdb-33dc8f53d043@moroto.mountain/Signed-off-by: default avatarRaag Jadav <raag.jadav@intel.com>
Acked-by: default avatarMika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
parent 0bb80ecc
...@@ -983,11 +983,18 @@ static int byt_pin_config_set(struct pinctrl_dev *pctl_dev, ...@@ -983,11 +983,18 @@ static int byt_pin_config_set(struct pinctrl_dev *pctl_dev,
break; break;
case PIN_CONFIG_INPUT_DEBOUNCE: case PIN_CONFIG_INPUT_DEBOUNCE:
if (arg) if (arg) {
conf |= BYT_DEBOUNCE_EN; conf |= BYT_DEBOUNCE_EN;
else } else {
conf &= ~BYT_DEBOUNCE_EN; conf &= ~BYT_DEBOUNCE_EN;
/*
* No need to update the pulse value.
* Debounce is going to be disabled.
*/
break;
}
switch (arg) { switch (arg) {
case 375: case 375:
db_pulse = BYT_DEBOUNCE_PULSE_375US; db_pulse = BYT_DEBOUNCE_PULSE_375US;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment