Commit 2d88a331 authored by Wei Yongjun's avatar Wei Yongjun Committed by Jacek Anaszewski

leds: leds-gpio: Fix return value check in create_gpio_led()

In case of error, the function gpio_to_desc() returns NULL
pointer not ERR_PTR(). The IS_ERR() test in the return value
check should be replaced with NULL test.
Signed-off-by: default avatarWei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: default avatarJacek Anaszewski <j.anaszewski@samsung.com>
parent c9eec908
...@@ -104,8 +104,8 @@ static int create_gpio_led(const struct gpio_led *template, ...@@ -104,8 +104,8 @@ static int create_gpio_led(const struct gpio_led *template,
return ret; return ret;
led_dat->gpiod = gpio_to_desc(template->gpio); led_dat->gpiod = gpio_to_desc(template->gpio);
if (IS_ERR(led_dat->gpiod)) if (!led_dat->gpiod)
return PTR_ERR(led_dat->gpiod); return -EINVAL;
} }
led_dat->cdev.name = template->name; led_dat->cdev.name = template->name;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment