Commit 2d99cf16 authored by Stanislaw Gruszka's avatar Stanislaw Gruszka Committed by David S. Miller

bnx2x: use smp_mb() to keep ordering of read write operations

Since we want to keep ordering of write to fp->bd_tx_cons and
netif_tx_queue_stopped(txq), what is read of txq->state, we have to use
general memory barrier.
Signed-off-by: default avatarStanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent d4a2ac3e
...@@ -963,7 +963,7 @@ static int bnx2x_tx_int(struct bnx2x_fastpath *fp) ...@@ -963,7 +963,7 @@ static int bnx2x_tx_int(struct bnx2x_fastpath *fp)
* start_xmit() will miss it and cause the queue to be stopped * start_xmit() will miss it and cause the queue to be stopped
* forever. * forever.
*/ */
smp_wmb(); smp_mb();
/* TBD need a thresh? */ /* TBD need a thresh? */
if (unlikely(netif_tx_queue_stopped(txq))) { if (unlikely(netif_tx_queue_stopped(txq))) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment