Commit 2da69b89 authored by Ido Yariv's avatar Ido Yariv Committed by Luciano Coelho

wl12xx: Switch to level trigger interrupts

The interrupt of the wl12xx is a level interrupt in nature, since the
interrupt line is not auto-reset. However, since resetting the interrupt
requires bus transactions, this cannot be done from an interrupt
context. Thus, requesting a level interrupt would require to disable the
irq and re-enable it after the HW is acknowledged. Since we now request
a threaded irq, this can also be done by specifying the IRQF_ONESHOT
flag.

Triggering on an edge can be problematic in some platforms, if the
sampling frequency is not sufficient for detecting very frequent
interrupts. In case an interrupt is missed, the driver will hang as the
interrupt line will stay high until it is acknowledged by the driver,
which will never happen.

Fix this by requesting a level triggered interrupt, with the
IRQF_ONESHOT flag.
Signed-off-by: default avatarIdo Yariv <ido@wizery.com>
Reviewed-by: default avatarLuciano Coelho <coelho@ti.com>
Signed-off-by: default avatarLuciano Coelho <coelho@ti.com>
parent a620865e
...@@ -241,7 +241,7 @@ static int __devinit wl1271_probe(struct sdio_func *func, ...@@ -241,7 +241,7 @@ static int __devinit wl1271_probe(struct sdio_func *func,
wl->ref_clock = wlan_data->board_ref_clock; wl->ref_clock = wlan_data->board_ref_clock;
ret = request_threaded_irq(wl->irq, wl1271_hardirq, wl1271_irq, ret = request_threaded_irq(wl->irq, wl1271_hardirq, wl1271_irq,
IRQF_TRIGGER_RISING, IRQF_TRIGGER_HIGH | IRQF_ONESHOT,
DRIVER_NAME, wl); DRIVER_NAME, wl);
if (ret < 0) { if (ret < 0) {
wl1271_error("request_irq() failed: %d", ret); wl1271_error("request_irq() failed: %d", ret);
......
...@@ -409,7 +409,7 @@ static int __devinit wl1271_probe(struct spi_device *spi) ...@@ -409,7 +409,7 @@ static int __devinit wl1271_probe(struct spi_device *spi)
} }
ret = request_threaded_irq(wl->irq, wl1271_hardirq, wl1271_irq, ret = request_threaded_irq(wl->irq, wl1271_hardirq, wl1271_irq,
IRQF_TRIGGER_RISING, IRQF_TRIGGER_HIGH | IRQF_ONESHOT,
DRIVER_NAME, wl); DRIVER_NAME, wl);
if (ret < 0) { if (ret < 0) {
wl1271_error("request_irq() failed: %d", ret); wl1271_error("request_irq() failed: %d", ret);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment