Commit 2db6c769 authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman

USB: cp210x: use generic submit_read_urb at open

There is no need to initialise the read urb as this is done at port
probe.
Signed-off-by: default avatarJohan Hovold <jhovold@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 056afc0f
...@@ -372,7 +372,6 @@ static unsigned int cp210x_quantise_baudrate(unsigned int baud) { ...@@ -372,7 +372,6 @@ static unsigned int cp210x_quantise_baudrate(unsigned int baud) {
static int cp210x_open(struct tty_struct *tty, struct usb_serial_port *port) static int cp210x_open(struct tty_struct *tty, struct usb_serial_port *port)
{ {
struct usb_serial *serial = port->serial;
int result; int result;
dbg("%s - port %d", __func__, port->number); dbg("%s - port %d", __func__, port->number);
...@@ -383,20 +382,9 @@ static int cp210x_open(struct tty_struct *tty, struct usb_serial_port *port) ...@@ -383,20 +382,9 @@ static int cp210x_open(struct tty_struct *tty, struct usb_serial_port *port)
return -EPROTO; return -EPROTO;
} }
/* Start reading from the device */ result = usb_serial_generic_submit_read_urb(port, GFP_KERNEL);
usb_fill_bulk_urb(port->read_urb, serial->dev, if (result)
usb_rcvbulkpipe(serial->dev,
port->bulk_in_endpointAddress),
port->read_urb->transfer_buffer,
port->read_urb->transfer_buffer_length,
serial->type->read_bulk_callback,
port);
result = usb_submit_urb(port->read_urb, GFP_KERNEL);
if (result) {
dev_err(&port->dev, "%s - failed resubmitting read urb, "
"error %d\n", __func__, result);
return result; return result;
}
/* Configure the termios structure */ /* Configure the termios structure */
cp210x_get_termios(tty, port); cp210x_get_termios(tty, port);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment