Commit 2e4930eb authored by Kees Cook's avatar Kees Cook Committed by James Morris

Yama: handle 32-bit userspace prctl

When running a 64-bit kernel and receiving prctls from a 32-bit
userspace, the "-1" used as an unsigned long will end up being
misdetected. The kernel is looking for 0xffffffffffffffff instead of
0xffffffff. Since prctl lacks a distinct compat interface, Yama needs
to handle this translation itself. As such, support either value as
meaning PR_SET_PTRACER_ANY, to avoid breaking the ABI for 64-bit.
Signed-off-by: default avatarKees Cook <keescook@chromium.org>
Acked-by: default avatarJohn Johansen <john.johansen@canonical.com>
Cc: stable@vger.kernel.org
Signed-off-by: default avatarJames Morris <james.l.morris@oracle.com>
parent c6993e4a
...@@ -143,7 +143,7 @@ int yama_task_prctl(int option, unsigned long arg2, unsigned long arg3, ...@@ -143,7 +143,7 @@ int yama_task_prctl(int option, unsigned long arg2, unsigned long arg3,
if (arg2 == 0) { if (arg2 == 0) {
yama_ptracer_del(NULL, myself); yama_ptracer_del(NULL, myself);
rc = 0; rc = 0;
} else if (arg2 == PR_SET_PTRACER_ANY) { } else if (arg2 == PR_SET_PTRACER_ANY || (int)arg2 == -1) {
rc = yama_ptracer_add(NULL, myself); rc = yama_ptracer_add(NULL, myself);
} else { } else {
struct task_struct *tracer; struct task_struct *tracer;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment