Commit 2e71c9e4 authored by Sudip Mukherjee's avatar Sudip Mukherjee Committed by Greg Kroah-Hartman

staging: unisys: use error codes

we were just returning -1 to the calling function which was again
returning that if the module failed to load. Now we are returning the
actual error codes.
Signed-off-by: default avatarSudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 6bdb6101
...@@ -56,18 +56,20 @@ visorchipset_file_init(dev_t major_dev, struct visorchannel **controlvm_channel) ...@@ -56,18 +56,20 @@ visorchipset_file_init(dev_t major_dev, struct visorchannel **controlvm_channel)
cdev_init(&file_cdev, &visorchipset_fops); cdev_init(&file_cdev, &visorchipset_fops);
file_cdev.owner = THIS_MODULE; file_cdev.owner = THIS_MODULE;
if (MAJOR(major_dev) == 0) { if (MAJOR(major_dev) == 0) {
rc = alloc_chrdev_region(&major_dev, 0, 1, MYDRVNAME);
/* dynamic major device number registration required */ /* dynamic major device number registration required */
if (alloc_chrdev_region(&major_dev, 0, 1, MYDRVNAME) < 0) if (rc < 0)
return -1; return rc;
} else { } else {
/* static major device number registration required */ /* static major device number registration required */
if (register_chrdev_region(major_dev, 1, MYDRVNAME) < 0) rc = register_chrdev_region(major_dev, 1, MYDRVNAME);
return -1; if (rc < 0)
return rc;
} }
rc = cdev_add(&file_cdev, MKDEV(MAJOR(major_dev), 0), 1); rc = cdev_add(&file_cdev, MKDEV(MAJOR(major_dev), 0), 1);
if (rc < 0) { if (rc < 0) {
unregister_chrdev_region(major_dev, 1); unregister_chrdev_region(major_dev, 1);
return -1; return rc;
} }
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment