Commit 2f6589df authored by Dawei Li's avatar Dawei Li Committed by Will Deacon

perf/alibaba_uncore_drw: Avoid placing cpumask on the stack

In general it's preferable to avoid placing cpumasks on the stack, as
for large values of NR_CPUS these can consume significant amounts of
stack space and make stack overflows more likely.

Use cpumask_any_and_but() to avoid the need for a temporary cpumask on
the stack.
Suggested-by: default avatarMark Rutland <mark.rutland@arm.com>
Reviewed-by: default avatarMark Rutland <mark.rutland@arm.com>
Signed-off-by: default avatarDawei Li <dawei.li@shingroup.cn>
Reviewed-by: default avatarShuai Xue <xueshuai@linux.alibaba.com>
Link: https://lore.kernel.org/r/20240403155950.2068109-3-dawei.li@shingroup.cnSigned-off-by: default avatarWill Deacon <will@kernel.org>
parent 897fa2c3
...@@ -746,18 +746,14 @@ static int ali_drw_pmu_offline_cpu(unsigned int cpu, struct hlist_node *node) ...@@ -746,18 +746,14 @@ static int ali_drw_pmu_offline_cpu(unsigned int cpu, struct hlist_node *node)
struct ali_drw_pmu_irq *irq; struct ali_drw_pmu_irq *irq;
struct ali_drw_pmu *drw_pmu; struct ali_drw_pmu *drw_pmu;
unsigned int target; unsigned int target;
int ret;
cpumask_t node_online_cpus;
irq = hlist_entry_safe(node, struct ali_drw_pmu_irq, node); irq = hlist_entry_safe(node, struct ali_drw_pmu_irq, node);
if (cpu != irq->cpu) if (cpu != irq->cpu)
return 0; return 0;
ret = cpumask_and(&node_online_cpus, target = cpumask_any_and_but(cpumask_of_node(cpu_to_node(cpu)),
cpumask_of_node(cpu_to_node(cpu)), cpu_online_mask); cpu_online_mask, cpu);
if (ret) if (target >= nr_cpu_ids)
target = cpumask_any_but(&node_online_cpus, cpu);
else
target = cpumask_any_but(cpu_online_mask, cpu); target = cpumask_any_but(cpu_online_mask, cpu);
if (target >= nr_cpu_ids) if (target >= nr_cpu_ids)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment