Commit 2f961952 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by David S. Miller

net: ethernet: tundra: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() is renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 231ea972
...@@ -1660,7 +1660,7 @@ static void tsi108_timed_checker(struct timer_list *t) ...@@ -1660,7 +1660,7 @@ static void tsi108_timed_checker(struct timer_list *t)
mod_timer(&data->timer, jiffies + CHECK_PHY_INTERVAL); mod_timer(&data->timer, jiffies + CHECK_PHY_INTERVAL);
} }
static int tsi108_ether_remove(struct platform_device *pdev) static void tsi108_ether_remove(struct platform_device *pdev)
{ {
struct net_device *dev = platform_get_drvdata(pdev); struct net_device *dev = platform_get_drvdata(pdev);
struct tsi108_prv_data *priv = netdev_priv(dev); struct tsi108_prv_data *priv = netdev_priv(dev);
...@@ -1670,15 +1670,13 @@ static int tsi108_ether_remove(struct platform_device *pdev) ...@@ -1670,15 +1670,13 @@ static int tsi108_ether_remove(struct platform_device *pdev)
iounmap(priv->regs); iounmap(priv->regs);
iounmap(priv->phyregs); iounmap(priv->phyregs);
free_netdev(dev); free_netdev(dev);
return 0;
} }
/* Structure for a device driver */ /* Structure for a device driver */
static struct platform_driver tsi_eth_driver = { static struct platform_driver tsi_eth_driver = {
.probe = tsi108_init_one, .probe = tsi108_init_one,
.remove = tsi108_ether_remove, .remove_new = tsi108_ether_remove,
.driver = { .driver = {
.name = "tsi-ethernet", .name = "tsi-ethernet",
}, },
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment