Commit 2f98e78b authored by Sebastian Reichel's avatar Sebastian Reichel Committed by Linus Walleij

pinctrl: mcp23s08: use managed kzalloc for mcp

Let's remove a few lines of code by using managed memory for mcp
variable.
Signed-off-by: default avatarSebastian Reichel <sebastian.reichel@collabora.co.uk>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 2e29e767
...@@ -1019,7 +1019,7 @@ static int mcp230xx_probe(struct i2c_client *client, ...@@ -1019,7 +1019,7 @@ static int mcp230xx_probe(struct i2c_client *client,
} }
} }
mcp = kzalloc(sizeof(*mcp), GFP_KERNEL); mcp = devm_kzalloc(&client->dev, sizeof(*mcp), GFP_KERNEL);
if (!mcp) if (!mcp)
return -ENOMEM; return -ENOMEM;
...@@ -1027,16 +1027,11 @@ static int mcp230xx_probe(struct i2c_client *client, ...@@ -1027,16 +1027,11 @@ static int mcp230xx_probe(struct i2c_client *client,
status = mcp23s08_probe_one(mcp, &client->dev, client, client->addr, status = mcp23s08_probe_one(mcp, &client->dev, client, client->addr,
id->driver_data, pdata, 0); id->driver_data, pdata, 0);
if (status) if (status)
goto fail; return status;
i2c_set_clientdata(client, mcp); i2c_set_clientdata(client, mcp);
return 0; return 0;
fail:
kfree(mcp);
return status;
} }
static int mcp230xx_remove(struct i2c_client *client) static int mcp230xx_remove(struct i2c_client *client)
...@@ -1044,7 +1039,6 @@ static int mcp230xx_remove(struct i2c_client *client) ...@@ -1044,7 +1039,6 @@ static int mcp230xx_remove(struct i2c_client *client)
struct mcp23s08 *mcp = i2c_get_clientdata(client); struct mcp23s08 *mcp = i2c_get_clientdata(client);
gpiochip_remove(&mcp->chip); gpiochip_remove(&mcp->chip);
kfree(mcp);
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment