Commit 2fea6cf7 authored by Marc Zyngier's avatar Marc Zyngier

Merge branch kvm-arm64/selftest/sysreg-list-fix into kvmarm-master/next

Selftest updates from Andrew Jones, fixing the sysgreg list
expectations by dealing with multiple configurations, such
as with or without a PMU.

* kvm-arm64/selftest/sysreg-list-fix:
  KVM: arm64: Update MAINTAINERS to include selftests
  KVM: arm64: selftests: get-reg-list: Split base and pmu registers
  KVM: arm64: selftests: get-reg-list: Remove get-reg-list-sve
  KVM: arm64: selftests: get-reg-list: Provide config selection option
  KVM: arm64: selftests: get-reg-list: Prepare to run multiple configs at once
  KVM: arm64: selftests: get-reg-list: Introduce vcpu configs
parents 85c653fc b356a831
...@@ -9993,6 +9993,8 @@ F: arch/arm64/include/asm/kvm* ...@@ -9993,6 +9993,8 @@ F: arch/arm64/include/asm/kvm*
F: arch/arm64/include/uapi/asm/kvm* F: arch/arm64/include/uapi/asm/kvm*
F: arch/arm64/kvm/ F: arch/arm64/kvm/
F: include/kvm/arm_* F: include/kvm/arm_*
F: tools/testing/selftests/kvm/*/aarch64/
F: tools/testing/selftests/kvm/aarch64/
KERNEL VIRTUAL MACHINE FOR MIPS (KVM/mips) KERNEL VIRTUAL MACHINE FOR MIPS (KVM/mips)
M: Huacai Chen <chenhuacai@kernel.org> M: Huacai Chen <chenhuacai@kernel.org>
......
# SPDX-License-Identifier: GPL-2.0-only # SPDX-License-Identifier: GPL-2.0-only
/aarch64/debug-exceptions /aarch64/debug-exceptions
/aarch64/get-reg-list /aarch64/get-reg-list
/aarch64/get-reg-list-sve
/aarch64/vgic_init /aarch64/vgic_init
/s390x/memop /s390x/memop
/s390x/resets /s390x/resets
......
...@@ -80,7 +80,6 @@ TEST_GEN_PROGS_x86_64 += steal_time ...@@ -80,7 +80,6 @@ TEST_GEN_PROGS_x86_64 += steal_time
TEST_GEN_PROGS_aarch64 += aarch64/debug-exceptions TEST_GEN_PROGS_aarch64 += aarch64/debug-exceptions
TEST_GEN_PROGS_aarch64 += aarch64/get-reg-list TEST_GEN_PROGS_aarch64 += aarch64/get-reg-list
TEST_GEN_PROGS_aarch64 += aarch64/get-reg-list-sve
TEST_GEN_PROGS_aarch64 += aarch64/vgic_init TEST_GEN_PROGS_aarch64 += aarch64/vgic_init
TEST_GEN_PROGS_aarch64 += demand_paging_test TEST_GEN_PROGS_aarch64 += demand_paging_test
TEST_GEN_PROGS_aarch64 += dirty_log_test TEST_GEN_PROGS_aarch64 += dirty_log_test
......
// SPDX-License-Identifier: GPL-2.0
#define REG_LIST_SVE
#include "get-reg-list.c"
...@@ -27,17 +27,37 @@ ...@@ -27,17 +27,37 @@
#include <stdio.h> #include <stdio.h>
#include <stdlib.h> #include <stdlib.h>
#include <string.h> #include <string.h>
#include <unistd.h>
#include <sys/types.h>
#include <sys/wait.h>
#include "kvm_util.h" #include "kvm_util.h"
#include "test_util.h" #include "test_util.h"
#include "processor.h" #include "processor.h"
#ifdef REG_LIST_SVE static struct kvm_reg_list *reg_list;
#define reg_list_sve() (true) static __u64 *blessed_reg, blessed_n;
#else
#define reg_list_sve() (false)
#endif
#define REG_MASK (KVM_REG_ARCH_MASK | KVM_REG_SIZE_MASK | KVM_REG_ARM_COPROC_MASK) struct reg_sublist {
const char *name;
long capability;
int feature;
bool finalize;
__u64 *regs;
__u64 regs_n;
__u64 *rejects_set;
__u64 rejects_set_n;
};
struct vcpu_config {
char *name;
struct reg_sublist sublists[];
};
static struct vcpu_config *vcpu_configs[];
static int vcpu_configs_n;
#define for_each_sublist(c, s) \
for ((s) = &(c)->sublists[0]; (s)->regs; ++(s))
#define for_each_reg(i) \ #define for_each_reg(i) \
for ((i) = 0; (i) < reg_list->n; ++(i)) for ((i) = 0; (i) < reg_list->n; ++(i))
...@@ -54,12 +74,41 @@ ...@@ -54,12 +74,41 @@
for_each_reg_filtered(i) \ for_each_reg_filtered(i) \
if (!find_reg(blessed_reg, blessed_n, reg_list->reg[i])) if (!find_reg(blessed_reg, blessed_n, reg_list->reg[i]))
static const char *config_name(struct vcpu_config *c)
{
struct reg_sublist *s;
int len = 0;
static struct kvm_reg_list *reg_list; if (c->name)
return c->name;
static __u64 base_regs[], vregs[], sve_regs[], rejects_set[]; for_each_sublist(c, s)
static __u64 base_regs_n, vregs_n, sve_regs_n, rejects_set_n; len += strlen(s->name) + 1;
static __u64 *blessed_reg, blessed_n;
c->name = malloc(len);
len = 0;
for_each_sublist(c, s) {
if (!strcmp(s->name, "base"))
continue;
strcat(c->name + len, s->name);
len += strlen(s->name) + 1;
c->name[len - 1] = '+';
}
c->name[len - 1] = '\0';
return c->name;
}
static bool has_cap(struct vcpu_config *c, long capability)
{
struct reg_sublist *s;
for_each_sublist(c, s)
if (s->capability == capability)
return true;
return false;
}
static bool filter_reg(__u64 reg) static bool filter_reg(__u64 reg)
{ {
...@@ -96,11 +145,13 @@ static const char *str_with_index(const char *template, __u64 index) ...@@ -96,11 +145,13 @@ static const char *str_with_index(const char *template, __u64 index)
return (const char *)str; return (const char *)str;
} }
#define REG_MASK (KVM_REG_ARCH_MASK | KVM_REG_SIZE_MASK | KVM_REG_ARM_COPROC_MASK)
#define CORE_REGS_XX_NR_WORDS 2 #define CORE_REGS_XX_NR_WORDS 2
#define CORE_SPSR_XX_NR_WORDS 2 #define CORE_SPSR_XX_NR_WORDS 2
#define CORE_FPREGS_XX_NR_WORDS 4 #define CORE_FPREGS_XX_NR_WORDS 4
static const char *core_id_to_str(__u64 id) static const char *core_id_to_str(struct vcpu_config *c, __u64 id)
{ {
__u64 core_off = id & ~REG_MASK, idx; __u64 core_off = id & ~REG_MASK, idx;
...@@ -111,7 +162,7 @@ static const char *core_id_to_str(__u64 id) ...@@ -111,7 +162,7 @@ static const char *core_id_to_str(__u64 id)
case KVM_REG_ARM_CORE_REG(regs.regs[0]) ... case KVM_REG_ARM_CORE_REG(regs.regs[0]) ...
KVM_REG_ARM_CORE_REG(regs.regs[30]): KVM_REG_ARM_CORE_REG(regs.regs[30]):
idx = (core_off - KVM_REG_ARM_CORE_REG(regs.regs[0])) / CORE_REGS_XX_NR_WORDS; idx = (core_off - KVM_REG_ARM_CORE_REG(regs.regs[0])) / CORE_REGS_XX_NR_WORDS;
TEST_ASSERT(idx < 31, "Unexpected regs.regs index: %lld", idx); TEST_ASSERT(idx < 31, "%s: Unexpected regs.regs index: %lld", config_name(c), idx);
return str_with_index("KVM_REG_ARM_CORE_REG(regs.regs[##])", idx); return str_with_index("KVM_REG_ARM_CORE_REG(regs.regs[##])", idx);
case KVM_REG_ARM_CORE_REG(regs.sp): case KVM_REG_ARM_CORE_REG(regs.sp):
return "KVM_REG_ARM_CORE_REG(regs.sp)"; return "KVM_REG_ARM_CORE_REG(regs.sp)";
...@@ -126,12 +177,12 @@ static const char *core_id_to_str(__u64 id) ...@@ -126,12 +177,12 @@ static const char *core_id_to_str(__u64 id)
case KVM_REG_ARM_CORE_REG(spsr[0]) ... case KVM_REG_ARM_CORE_REG(spsr[0]) ...
KVM_REG_ARM_CORE_REG(spsr[KVM_NR_SPSR - 1]): KVM_REG_ARM_CORE_REG(spsr[KVM_NR_SPSR - 1]):
idx = (core_off - KVM_REG_ARM_CORE_REG(spsr[0])) / CORE_SPSR_XX_NR_WORDS; idx = (core_off - KVM_REG_ARM_CORE_REG(spsr[0])) / CORE_SPSR_XX_NR_WORDS;
TEST_ASSERT(idx < KVM_NR_SPSR, "Unexpected spsr index: %lld", idx); TEST_ASSERT(idx < KVM_NR_SPSR, "%s: Unexpected spsr index: %lld", config_name(c), idx);
return str_with_index("KVM_REG_ARM_CORE_REG(spsr[##])", idx); return str_with_index("KVM_REG_ARM_CORE_REG(spsr[##])", idx);
case KVM_REG_ARM_CORE_REG(fp_regs.vregs[0]) ... case KVM_REG_ARM_CORE_REG(fp_regs.vregs[0]) ...
KVM_REG_ARM_CORE_REG(fp_regs.vregs[31]): KVM_REG_ARM_CORE_REG(fp_regs.vregs[31]):
idx = (core_off - KVM_REG_ARM_CORE_REG(fp_regs.vregs[0])) / CORE_FPREGS_XX_NR_WORDS; idx = (core_off - KVM_REG_ARM_CORE_REG(fp_regs.vregs[0])) / CORE_FPREGS_XX_NR_WORDS;
TEST_ASSERT(idx < 32, "Unexpected fp_regs.vregs index: %lld", idx); TEST_ASSERT(idx < 32, "%s: Unexpected fp_regs.vregs index: %lld", config_name(c), idx);
return str_with_index("KVM_REG_ARM_CORE_REG(fp_regs.vregs[##])", idx); return str_with_index("KVM_REG_ARM_CORE_REG(fp_regs.vregs[##])", idx);
case KVM_REG_ARM_CORE_REG(fp_regs.fpsr): case KVM_REG_ARM_CORE_REG(fp_regs.fpsr):
return "KVM_REG_ARM_CORE_REG(fp_regs.fpsr)"; return "KVM_REG_ARM_CORE_REG(fp_regs.fpsr)";
...@@ -139,11 +190,11 @@ static const char *core_id_to_str(__u64 id) ...@@ -139,11 +190,11 @@ static const char *core_id_to_str(__u64 id)
return "KVM_REG_ARM_CORE_REG(fp_regs.fpcr)"; return "KVM_REG_ARM_CORE_REG(fp_regs.fpcr)";
} }
TEST_FAIL("Unknown core reg id: 0x%llx", id); TEST_FAIL("%s: Unknown core reg id: 0x%llx", config_name(c), id);
return NULL; return NULL;
} }
static const char *sve_id_to_str(__u64 id) static const char *sve_id_to_str(struct vcpu_config *c, __u64 id)
{ {
__u64 sve_off, n, i; __u64 sve_off, n, i;
...@@ -153,37 +204,37 @@ static const char *sve_id_to_str(__u64 id) ...@@ -153,37 +204,37 @@ static const char *sve_id_to_str(__u64 id)
sve_off = id & ~(REG_MASK | ((1ULL << 5) - 1)); sve_off = id & ~(REG_MASK | ((1ULL << 5) - 1));
i = id & (KVM_ARM64_SVE_MAX_SLICES - 1); i = id & (KVM_ARM64_SVE_MAX_SLICES - 1);
TEST_ASSERT(i == 0, "Currently we don't expect slice > 0, reg id 0x%llx", id); TEST_ASSERT(i == 0, "%s: Currently we don't expect slice > 0, reg id 0x%llx", config_name(c), id);
switch (sve_off) { switch (sve_off) {
case KVM_REG_ARM64_SVE_ZREG_BASE ... case KVM_REG_ARM64_SVE_ZREG_BASE ...
KVM_REG_ARM64_SVE_ZREG_BASE + (1ULL << 5) * KVM_ARM64_SVE_NUM_ZREGS - 1: KVM_REG_ARM64_SVE_ZREG_BASE + (1ULL << 5) * KVM_ARM64_SVE_NUM_ZREGS - 1:
n = (id >> 5) & (KVM_ARM64_SVE_NUM_ZREGS - 1); n = (id >> 5) & (KVM_ARM64_SVE_NUM_ZREGS - 1);
TEST_ASSERT(id == KVM_REG_ARM64_SVE_ZREG(n, 0), TEST_ASSERT(id == KVM_REG_ARM64_SVE_ZREG(n, 0),
"Unexpected bits set in SVE ZREG id: 0x%llx", id); "%s: Unexpected bits set in SVE ZREG id: 0x%llx", config_name(c), id);
return str_with_index("KVM_REG_ARM64_SVE_ZREG(##, 0)", n); return str_with_index("KVM_REG_ARM64_SVE_ZREG(##, 0)", n);
case KVM_REG_ARM64_SVE_PREG_BASE ... case KVM_REG_ARM64_SVE_PREG_BASE ...
KVM_REG_ARM64_SVE_PREG_BASE + (1ULL << 5) * KVM_ARM64_SVE_NUM_PREGS - 1: KVM_REG_ARM64_SVE_PREG_BASE + (1ULL << 5) * KVM_ARM64_SVE_NUM_PREGS - 1:
n = (id >> 5) & (KVM_ARM64_SVE_NUM_PREGS - 1); n = (id >> 5) & (KVM_ARM64_SVE_NUM_PREGS - 1);
TEST_ASSERT(id == KVM_REG_ARM64_SVE_PREG(n, 0), TEST_ASSERT(id == KVM_REG_ARM64_SVE_PREG(n, 0),
"Unexpected bits set in SVE PREG id: 0x%llx", id); "%s: Unexpected bits set in SVE PREG id: 0x%llx", config_name(c), id);
return str_with_index("KVM_REG_ARM64_SVE_PREG(##, 0)", n); return str_with_index("KVM_REG_ARM64_SVE_PREG(##, 0)", n);
case KVM_REG_ARM64_SVE_FFR_BASE: case KVM_REG_ARM64_SVE_FFR_BASE:
TEST_ASSERT(id == KVM_REG_ARM64_SVE_FFR(0), TEST_ASSERT(id == KVM_REG_ARM64_SVE_FFR(0),
"Unexpected bits set in SVE FFR id: 0x%llx", id); "%s: Unexpected bits set in SVE FFR id: 0x%llx", config_name(c), id);
return "KVM_REG_ARM64_SVE_FFR(0)"; return "KVM_REG_ARM64_SVE_FFR(0)";
} }
return NULL; return NULL;
} }
static void print_reg(__u64 id) static void print_reg(struct vcpu_config *c, __u64 id)
{ {
unsigned op0, op1, crn, crm, op2; unsigned op0, op1, crn, crm, op2;
const char *reg_size = NULL; const char *reg_size = NULL;
TEST_ASSERT((id & KVM_REG_ARCH_MASK) == KVM_REG_ARM64, TEST_ASSERT((id & KVM_REG_ARCH_MASK) == KVM_REG_ARM64,
"KVM_REG_ARM64 missing in reg id: 0x%llx", id); "%s: KVM_REG_ARM64 missing in reg id: 0x%llx", config_name(c), id);
switch (id & KVM_REG_SIZE_MASK) { switch (id & KVM_REG_SIZE_MASK) {
case KVM_REG_SIZE_U8: case KVM_REG_SIZE_U8:
...@@ -214,17 +265,17 @@ static void print_reg(__u64 id) ...@@ -214,17 +265,17 @@ static void print_reg(__u64 id)
reg_size = "KVM_REG_SIZE_U2048"; reg_size = "KVM_REG_SIZE_U2048";
break; break;
default: default:
TEST_FAIL("Unexpected reg size: 0x%llx in reg id: 0x%llx", TEST_FAIL("%s: Unexpected reg size: 0x%llx in reg id: 0x%llx",
(id & KVM_REG_SIZE_MASK) >> KVM_REG_SIZE_SHIFT, id); config_name(c), (id & KVM_REG_SIZE_MASK) >> KVM_REG_SIZE_SHIFT, id);
} }
switch (id & KVM_REG_ARM_COPROC_MASK) { switch (id & KVM_REG_ARM_COPROC_MASK) {
case KVM_REG_ARM_CORE: case KVM_REG_ARM_CORE:
printf("\tKVM_REG_ARM64 | %s | KVM_REG_ARM_CORE | %s,\n", reg_size, core_id_to_str(id)); printf("\tKVM_REG_ARM64 | %s | KVM_REG_ARM_CORE | %s,\n", reg_size, core_id_to_str(c, id));
break; break;
case KVM_REG_ARM_DEMUX: case KVM_REG_ARM_DEMUX:
TEST_ASSERT(!(id & ~(REG_MASK | KVM_REG_ARM_DEMUX_ID_MASK | KVM_REG_ARM_DEMUX_VAL_MASK)), TEST_ASSERT(!(id & ~(REG_MASK | KVM_REG_ARM_DEMUX_ID_MASK | KVM_REG_ARM_DEMUX_VAL_MASK)),
"Unexpected bits set in DEMUX reg id: 0x%llx", id); "%s: Unexpected bits set in DEMUX reg id: 0x%llx", config_name(c), id);
printf("\tKVM_REG_ARM64 | %s | KVM_REG_ARM_DEMUX | KVM_REG_ARM_DEMUX_ID_CCSIDR | %lld,\n", printf("\tKVM_REG_ARM64 | %s | KVM_REG_ARM_DEMUX | KVM_REG_ARM_DEMUX_ID_CCSIDR | %lld,\n",
reg_size, id & KVM_REG_ARM_DEMUX_VAL_MASK); reg_size, id & KVM_REG_ARM_DEMUX_VAL_MASK);
break; break;
...@@ -235,23 +286,23 @@ static void print_reg(__u64 id) ...@@ -235,23 +286,23 @@ static void print_reg(__u64 id)
crm = (id & KVM_REG_ARM64_SYSREG_CRM_MASK) >> KVM_REG_ARM64_SYSREG_CRM_SHIFT; crm = (id & KVM_REG_ARM64_SYSREG_CRM_MASK) >> KVM_REG_ARM64_SYSREG_CRM_SHIFT;
op2 = (id & KVM_REG_ARM64_SYSREG_OP2_MASK) >> KVM_REG_ARM64_SYSREG_OP2_SHIFT; op2 = (id & KVM_REG_ARM64_SYSREG_OP2_MASK) >> KVM_REG_ARM64_SYSREG_OP2_SHIFT;
TEST_ASSERT(id == ARM64_SYS_REG(op0, op1, crn, crm, op2), TEST_ASSERT(id == ARM64_SYS_REG(op0, op1, crn, crm, op2),
"Unexpected bits set in SYSREG reg id: 0x%llx", id); "%s: Unexpected bits set in SYSREG reg id: 0x%llx", config_name(c), id);
printf("\tARM64_SYS_REG(%d, %d, %d, %d, %d),\n", op0, op1, crn, crm, op2); printf("\tARM64_SYS_REG(%d, %d, %d, %d, %d),\n", op0, op1, crn, crm, op2);
break; break;
case KVM_REG_ARM_FW: case KVM_REG_ARM_FW:
TEST_ASSERT(id == KVM_REG_ARM_FW_REG(id & 0xffff), TEST_ASSERT(id == KVM_REG_ARM_FW_REG(id & 0xffff),
"Unexpected bits set in FW reg id: 0x%llx", id); "%s: Unexpected bits set in FW reg id: 0x%llx", config_name(c), id);
printf("\tKVM_REG_ARM_FW_REG(%lld),\n", id & 0xffff); printf("\tKVM_REG_ARM_FW_REG(%lld),\n", id & 0xffff);
break; break;
case KVM_REG_ARM64_SVE: case KVM_REG_ARM64_SVE:
if (reg_list_sve()) if (has_cap(c, KVM_CAP_ARM_SVE))
printf("\t%s,\n", sve_id_to_str(id)); printf("\t%s,\n", sve_id_to_str(c, id));
else else
TEST_FAIL("KVM_REG_ARM64_SVE is an unexpected coproc type in reg id: 0x%llx", id); TEST_FAIL("%s: KVM_REG_ARM64_SVE is an unexpected coproc type in reg id: 0x%llx", config_name(c), id);
break; break;
default: default:
TEST_FAIL("Unexpected coproc type: 0x%llx in reg id: 0x%llx", TEST_FAIL("%s: Unexpected coproc type: 0x%llx in reg id: 0x%llx",
(id & KVM_REG_ARM_COPROC_MASK) >> KVM_REG_ARM_COPROC_SHIFT, id); config_name(c), (id & KVM_REG_ARM_COPROC_MASK) >> KVM_REG_ARM_COPROC_SHIFT, id);
} }
} }
...@@ -312,56 +363,58 @@ static void core_reg_fixup(void) ...@@ -312,56 +363,58 @@ static void core_reg_fixup(void)
reg_list = tmp; reg_list = tmp;
} }
static void prepare_vcpu_init(struct kvm_vcpu_init *init) static void prepare_vcpu_init(struct vcpu_config *c, struct kvm_vcpu_init *init)
{ {
if (reg_list_sve()) struct reg_sublist *s;
init->features[0] |= 1 << KVM_ARM_VCPU_SVE;
for_each_sublist(c, s)
if (s->capability)
init->features[s->feature / 32] |= 1 << (s->feature % 32);
} }
static void finalize_vcpu(struct kvm_vm *vm, uint32_t vcpuid) static void finalize_vcpu(struct kvm_vm *vm, uint32_t vcpuid, struct vcpu_config *c)
{ {
struct reg_sublist *s;
int feature; int feature;
if (reg_list_sve()) { for_each_sublist(c, s) {
feature = KVM_ARM_VCPU_SVE; if (s->finalize) {
feature = s->feature;
vcpu_ioctl(vm, vcpuid, KVM_ARM_VCPU_FINALIZE, &feature); vcpu_ioctl(vm, vcpuid, KVM_ARM_VCPU_FINALIZE, &feature);
} }
}
} }
static void check_supported(void) static void check_supported(struct vcpu_config *c)
{ {
if (reg_list_sve() && !kvm_check_cap(KVM_CAP_ARM_SVE)) { struct reg_sublist *s;
fprintf(stderr, "SVE not available, skipping tests\n");
for_each_sublist(c, s) {
if (s->capability && !kvm_check_cap(s->capability)) {
fprintf(stderr, "%s: %s not available, skipping tests\n", config_name(c), s->name);
exit(KSFT_SKIP); exit(KSFT_SKIP);
} }
}
} }
int main(int ac, char **av) static bool print_list;
static bool print_filtered;
static bool fixup_core_regs;
static void run_test(struct vcpu_config *c)
{ {
struct kvm_vcpu_init init = { .target = -1, }; struct kvm_vcpu_init init = { .target = -1, };
int new_regs = 0, missing_regs = 0, i; int new_regs = 0, missing_regs = 0, i, n;
int failed_get = 0, failed_set = 0, failed_reject = 0; int failed_get = 0, failed_set = 0, failed_reject = 0;
bool print_list = false, print_filtered = false, fixup_core_regs = false;
struct kvm_vm *vm; struct kvm_vm *vm;
__u64 *vec_regs; struct reg_sublist *s;
check_supported(); check_supported(c);
for (i = 1; i < ac; ++i) {
if (strcmp(av[i], "--core-reg-fixup") == 0)
fixup_core_regs = true;
else if (strcmp(av[i], "--list") == 0)
print_list = true;
else if (strcmp(av[i], "--list-filtered") == 0)
print_filtered = true;
else
TEST_FAIL("Unknown option: %s\n", av[i]);
}
vm = vm_create(VM_MODE_DEFAULT, DEFAULT_GUEST_PHY_PAGES, O_RDWR); vm = vm_create(VM_MODE_DEFAULT, DEFAULT_GUEST_PHY_PAGES, O_RDWR);
prepare_vcpu_init(&init); prepare_vcpu_init(c, &init);
aarch64_vcpu_add_default(vm, 0, &init, NULL); aarch64_vcpu_add_default(vm, 0, &init, NULL);
finalize_vcpu(vm, 0); finalize_vcpu(vm, 0, c);
reg_list = vcpu_get_reg_list(vm, 0); reg_list = vcpu_get_reg_list(vm, 0);
...@@ -374,10 +427,10 @@ int main(int ac, char **av) ...@@ -374,10 +427,10 @@ int main(int ac, char **av)
__u64 id = reg_list->reg[i]; __u64 id = reg_list->reg[i];
if ((print_list && !filter_reg(id)) || if ((print_list && !filter_reg(id)) ||
(print_filtered && filter_reg(id))) (print_filtered && filter_reg(id)))
print_reg(id); print_reg(c, id);
} }
putchar('\n'); putchar('\n');
return 0; return;
} }
/* /*
...@@ -396,50 +449,52 @@ int main(int ac, char **av) ...@@ -396,50 +449,52 @@ int main(int ac, char **av)
.id = reg_list->reg[i], .id = reg_list->reg[i],
.addr = (__u64)&addr, .addr = (__u64)&addr,
}; };
bool reject_reg = false;
int ret; int ret;
ret = _vcpu_ioctl(vm, 0, KVM_GET_ONE_REG, &reg); ret = _vcpu_ioctl(vm, 0, KVM_GET_ONE_REG, &reg);
if (ret) { if (ret) {
puts("Failed to get "); printf("%s: Failed to get ", config_name(c));
print_reg(reg.id); print_reg(c, reg.id);
putchar('\n'); putchar('\n');
++failed_get; ++failed_get;
} }
/* rejects_set registers are rejected after KVM_ARM_VCPU_FINALIZE */ /* rejects_set registers are rejected after KVM_ARM_VCPU_FINALIZE */
if (find_reg(rejects_set, rejects_set_n, reg.id)) { for_each_sublist(c, s) {
if (s->rejects_set && find_reg(s->rejects_set, s->rejects_set_n, reg.id)) {
reject_reg = true;
ret = _vcpu_ioctl(vm, 0, KVM_SET_ONE_REG, &reg); ret = _vcpu_ioctl(vm, 0, KVM_SET_ONE_REG, &reg);
if (ret != -1 || errno != EPERM) { if (ret != -1 || errno != EPERM) {
printf("Failed to reject (ret=%d, errno=%d) ", ret, errno); printf("%s: Failed to reject (ret=%d, errno=%d) ", config_name(c), ret, errno);
print_reg(reg.id); print_reg(c, reg.id);
putchar('\n'); putchar('\n');
++failed_reject; ++failed_reject;
} }
continue; break;
}
} }
if (!reject_reg) {
ret = _vcpu_ioctl(vm, 0, KVM_SET_ONE_REG, &reg); ret = _vcpu_ioctl(vm, 0, KVM_SET_ONE_REG, &reg);
if (ret) { if (ret) {
puts("Failed to set "); printf("%s: Failed to set ", config_name(c));
print_reg(reg.id); print_reg(c, reg.id);
putchar('\n'); putchar('\n');
++failed_set; ++failed_set;
} }
} }
if (reg_list_sve()) {
blessed_n = base_regs_n + sve_regs_n;
vec_regs = sve_regs;
} else {
blessed_n = base_regs_n + vregs_n;
vec_regs = vregs;
} }
for_each_sublist(c, s)
blessed_n += s->regs_n;
blessed_reg = calloc(blessed_n, sizeof(__u64)); blessed_reg = calloc(blessed_n, sizeof(__u64));
for (i = 0; i < base_regs_n; ++i)
blessed_reg[i] = base_regs[i]; n = 0;
for (i = 0; i < blessed_n - base_regs_n; ++i) for_each_sublist(c, s) {
blessed_reg[base_regs_n + i] = vec_regs[i]; for (i = 0; i < s->regs_n; ++i)
blessed_reg[n++] = s->regs[i];
}
for_each_new_reg(i) for_each_new_reg(i)
++new_regs; ++new_regs;
...@@ -448,40 +503,141 @@ int main(int ac, char **av) ...@@ -448,40 +503,141 @@ int main(int ac, char **av)
++missing_regs; ++missing_regs;
if (new_regs || missing_regs) { if (new_regs || missing_regs) {
printf("Number blessed registers: %5lld\n", blessed_n); printf("%s: Number blessed registers: %5lld\n", config_name(c), blessed_n);
printf("Number registers: %5lld\n", reg_list->n); printf("%s: Number registers: %5lld\n", config_name(c), reg_list->n);
} }
if (new_regs) { if (new_regs) {
printf("\nThere are %d new registers.\n" printf("\n%s: There are %d new registers.\n"
"Consider adding them to the blessed reg " "Consider adding them to the blessed reg "
"list with the following lines:\n\n", new_regs); "list with the following lines:\n\n", config_name(c), new_regs);
for_each_new_reg(i) for_each_new_reg(i)
print_reg(reg_list->reg[i]); print_reg(c, reg_list->reg[i]);
putchar('\n'); putchar('\n');
} }
if (missing_regs) { if (missing_regs) {
printf("\nThere are %d missing registers.\n" printf("\n%s: There are %d missing registers.\n"
"The following lines are missing registers:\n\n", missing_regs); "The following lines are missing registers:\n\n", config_name(c), missing_regs);
for_each_missing_reg(i) for_each_missing_reg(i)
print_reg(blessed_reg[i]); print_reg(c, blessed_reg[i]);
putchar('\n'); putchar('\n');
} }
TEST_ASSERT(!missing_regs && !failed_get && !failed_set && !failed_reject, TEST_ASSERT(!missing_regs && !failed_get && !failed_set && !failed_reject,
"There are %d missing registers; " "%s: There are %d missing registers; "
"%d registers failed get; %d registers failed set; %d registers failed reject", "%d registers failed get; %d registers failed set; %d registers failed reject",
missing_regs, failed_get, failed_set, failed_reject); config_name(c), missing_regs, failed_get, failed_set, failed_reject);
pr_info("%s: PASS\n", config_name(c));
blessed_n = 0;
free(blessed_reg);
free(reg_list);
kvm_vm_free(vm);
}
static void help(void)
{
struct vcpu_config *c;
int i;
printf(
"\n"
"usage: get-reg-list [--config=<selection>] [--list] [--list-filtered] [--core-reg-fixup]\n\n"
" --config=<selection> Used to select a specific vcpu configuration for the test/listing\n"
" '<selection>' may be\n");
for (i = 0; i < vcpu_configs_n; ++i) {
c = vcpu_configs[i];
printf(
" '%s'\n", config_name(c));
}
printf(
"\n"
" --list Print the register list rather than test it (requires --config)\n"
" --list-filtered Print registers that would normally be filtered out (requires --config)\n"
" --core-reg-fixup Needed when running on old kernels with broken core reg listings\n"
"\n"
);
}
static struct vcpu_config *parse_config(const char *config)
{
struct vcpu_config *c;
int i;
if (config[8] != '=')
help(), exit(1);
for (i = 0; i < vcpu_configs_n; ++i) {
c = vcpu_configs[i];
if (strcmp(config_name(c), &config[9]) == 0)
break;
}
return 0; if (i == vcpu_configs_n)
help(), exit(1);
return c;
}
int main(int ac, char **av)
{
struct vcpu_config *c, *sel = NULL;
int i, ret = 0;
pid_t pid;
for (i = 1; i < ac; ++i) {
if (strcmp(av[i], "--core-reg-fixup") == 0)
fixup_core_regs = true;
else if (strncmp(av[i], "--config", 8) == 0)
sel = parse_config(av[i]);
else if (strcmp(av[i], "--list") == 0)
print_list = true;
else if (strcmp(av[i], "--list-filtered") == 0)
print_filtered = true;
else if (strcmp(av[i], "--help") == 0 || strcmp(av[1], "-h") == 0)
help(), exit(0);
else
help(), exit(1);
}
if (print_list || print_filtered) {
/*
* We only want to print the register list of a single config.
*/
if (!sel)
help(), exit(1);
}
for (i = 0; i < vcpu_configs_n; ++i) {
c = vcpu_configs[i];
if (sel && c != sel)
continue;
pid = fork();
if (!pid) {
run_test(c);
exit(0);
} else {
int wstatus;
pid_t wpid = wait(&wstatus);
TEST_ASSERT(wpid == pid && WIFEXITED(wstatus), "wait: Unexpected return");
if (WEXITSTATUS(wstatus) && WEXITSTATUS(wstatus) != KSFT_SKIP)
ret = KSFT_FAIL;
}
}
return ret;
} }
/* /*
* The current blessed list was primed with the output of kernel version * The current blessed list was primed with the output of kernel version
* v4.15 with --core-reg-fixup and then later updated with new registers. * v4.15 with --core-reg-fixup and then later updated with new registers.
* *
* The blessed list is up to date with kernel version v5.10-rc5 * The blessed list is up to date with kernel version v5.13-rc3
*/ */
static __u64 base_regs[] = { static __u64 base_regs[] = {
KVM_REG_ARM64 | KVM_REG_SIZE_U64 | KVM_REG_ARM_CORE | KVM_REG_ARM_CORE_REG(regs.regs[0]), KVM_REG_ARM64 | KVM_REG_SIZE_U64 | KVM_REG_ARM_CORE | KVM_REG_ARM_CORE_REG(regs.regs[0]),
...@@ -673,8 +829,6 @@ static __u64 base_regs[] = { ...@@ -673,8 +829,6 @@ static __u64 base_regs[] = {
ARM64_SYS_REG(3, 0, 5, 2, 0), /* ESR_EL1 */ ARM64_SYS_REG(3, 0, 5, 2, 0), /* ESR_EL1 */
ARM64_SYS_REG(3, 0, 6, 0, 0), /* FAR_EL1 */ ARM64_SYS_REG(3, 0, 6, 0, 0), /* FAR_EL1 */
ARM64_SYS_REG(3, 0, 7, 4, 0), /* PAR_EL1 */ ARM64_SYS_REG(3, 0, 7, 4, 0), /* PAR_EL1 */
ARM64_SYS_REG(3, 0, 9, 14, 1), /* PMINTENSET_EL1 */
ARM64_SYS_REG(3, 0, 9, 14, 2), /* PMINTENCLR_EL1 */
ARM64_SYS_REG(3, 0, 10, 2, 0), /* MAIR_EL1 */ ARM64_SYS_REG(3, 0, 10, 2, 0), /* MAIR_EL1 */
ARM64_SYS_REG(3, 0, 10, 3, 0), /* AMAIR_EL1 */ ARM64_SYS_REG(3, 0, 10, 3, 0), /* AMAIR_EL1 */
ARM64_SYS_REG(3, 0, 12, 0, 0), /* VBAR_EL1 */ ARM64_SYS_REG(3, 0, 12, 0, 0), /* VBAR_EL1 */
...@@ -683,6 +837,16 @@ static __u64 base_regs[] = { ...@@ -683,6 +837,16 @@ static __u64 base_regs[] = {
ARM64_SYS_REG(3, 0, 13, 0, 4), /* TPIDR_EL1 */ ARM64_SYS_REG(3, 0, 13, 0, 4), /* TPIDR_EL1 */
ARM64_SYS_REG(3, 0, 14, 1, 0), /* CNTKCTL_EL1 */ ARM64_SYS_REG(3, 0, 14, 1, 0), /* CNTKCTL_EL1 */
ARM64_SYS_REG(3, 2, 0, 0, 0), /* CSSELR_EL1 */ ARM64_SYS_REG(3, 2, 0, 0, 0), /* CSSELR_EL1 */
ARM64_SYS_REG(3, 3, 13, 0, 2), /* TPIDR_EL0 */
ARM64_SYS_REG(3, 3, 13, 0, 3), /* TPIDRRO_EL0 */
ARM64_SYS_REG(3, 4, 3, 0, 0), /* DACR32_EL2 */
ARM64_SYS_REG(3, 4, 5, 0, 1), /* IFSR32_EL2 */
ARM64_SYS_REG(3, 4, 5, 3, 0), /* FPEXC32_EL2 */
};
static __u64 pmu_regs[] = {
ARM64_SYS_REG(3, 0, 9, 14, 1), /* PMINTENSET_EL1 */
ARM64_SYS_REG(3, 0, 9, 14, 2), /* PMINTENCLR_EL1 */
ARM64_SYS_REG(3, 3, 9, 12, 0), /* PMCR_EL0 */ ARM64_SYS_REG(3, 3, 9, 12, 0), /* PMCR_EL0 */
ARM64_SYS_REG(3, 3, 9, 12, 1), /* PMCNTENSET_EL0 */ ARM64_SYS_REG(3, 3, 9, 12, 1), /* PMCNTENSET_EL0 */
ARM64_SYS_REG(3, 3, 9, 12, 2), /* PMCNTENCLR_EL0 */ ARM64_SYS_REG(3, 3, 9, 12, 2), /* PMCNTENCLR_EL0 */
...@@ -692,8 +856,6 @@ static __u64 base_regs[] = { ...@@ -692,8 +856,6 @@ static __u64 base_regs[] = {
ARM64_SYS_REG(3, 3, 9, 13, 0), /* PMCCNTR_EL0 */ ARM64_SYS_REG(3, 3, 9, 13, 0), /* PMCCNTR_EL0 */
ARM64_SYS_REG(3, 3, 9, 14, 0), /* PMUSERENR_EL0 */ ARM64_SYS_REG(3, 3, 9, 14, 0), /* PMUSERENR_EL0 */
ARM64_SYS_REG(3, 3, 9, 14, 3), /* PMOVSSET_EL0 */ ARM64_SYS_REG(3, 3, 9, 14, 3), /* PMOVSSET_EL0 */
ARM64_SYS_REG(3, 3, 13, 0, 2), /* TPIDR_EL0 */
ARM64_SYS_REG(3, 3, 13, 0, 3), /* TPIDRRO_EL0 */
ARM64_SYS_REG(3, 3, 14, 8, 0), ARM64_SYS_REG(3, 3, 14, 8, 0),
ARM64_SYS_REG(3, 3, 14, 8, 1), ARM64_SYS_REG(3, 3, 14, 8, 1),
ARM64_SYS_REG(3, 3, 14, 8, 2), ARM64_SYS_REG(3, 3, 14, 8, 2),
...@@ -757,11 +919,7 @@ static __u64 base_regs[] = { ...@@ -757,11 +919,7 @@ static __u64 base_regs[] = {
ARM64_SYS_REG(3, 3, 14, 15, 5), ARM64_SYS_REG(3, 3, 14, 15, 5),
ARM64_SYS_REG(3, 3, 14, 15, 6), ARM64_SYS_REG(3, 3, 14, 15, 6),
ARM64_SYS_REG(3, 3, 14, 15, 7), /* PMCCFILTR_EL0 */ ARM64_SYS_REG(3, 3, 14, 15, 7), /* PMCCFILTR_EL0 */
ARM64_SYS_REG(3, 4, 3, 0, 0), /* DACR32_EL2 */
ARM64_SYS_REG(3, 4, 5, 0, 1), /* IFSR32_EL2 */
ARM64_SYS_REG(3, 4, 5, 3, 0), /* FPEXC32_EL2 */
}; };
static __u64 base_regs_n = ARRAY_SIZE(base_regs);
static __u64 vregs[] = { static __u64 vregs[] = {
KVM_REG_ARM64 | KVM_REG_SIZE_U128 | KVM_REG_ARM_CORE | KVM_REG_ARM_CORE_REG(fp_regs.vregs[0]), KVM_REG_ARM64 | KVM_REG_SIZE_U128 | KVM_REG_ARM_CORE | KVM_REG_ARM_CORE_REG(fp_regs.vregs[0]),
...@@ -797,7 +955,6 @@ static __u64 vregs[] = { ...@@ -797,7 +955,6 @@ static __u64 vregs[] = {
KVM_REG_ARM64 | KVM_REG_SIZE_U128 | KVM_REG_ARM_CORE | KVM_REG_ARM_CORE_REG(fp_regs.vregs[30]), KVM_REG_ARM64 | KVM_REG_SIZE_U128 | KVM_REG_ARM_CORE | KVM_REG_ARM_CORE_REG(fp_regs.vregs[30]),
KVM_REG_ARM64 | KVM_REG_SIZE_U128 | KVM_REG_ARM_CORE | KVM_REG_ARM_CORE_REG(fp_regs.vregs[31]), KVM_REG_ARM64 | KVM_REG_SIZE_U128 | KVM_REG_ARM_CORE | KVM_REG_ARM_CORE_REG(fp_regs.vregs[31]),
}; };
static __u64 vregs_n = ARRAY_SIZE(vregs);
static __u64 sve_regs[] = { static __u64 sve_regs[] = {
KVM_REG_ARM64_SVE_VLS, KVM_REG_ARM64_SVE_VLS,
...@@ -852,11 +1009,57 @@ static __u64 sve_regs[] = { ...@@ -852,11 +1009,57 @@ static __u64 sve_regs[] = {
KVM_REG_ARM64_SVE_FFR(0), KVM_REG_ARM64_SVE_FFR(0),
ARM64_SYS_REG(3, 0, 1, 2, 0), /* ZCR_EL1 */ ARM64_SYS_REG(3, 0, 1, 2, 0), /* ZCR_EL1 */
}; };
static __u64 sve_regs_n = ARRAY_SIZE(sve_regs);
static __u64 rejects_set[] = { static __u64 sve_rejects_set[] = {
#ifdef REG_LIST_SVE
KVM_REG_ARM64_SVE_VLS, KVM_REG_ARM64_SVE_VLS,
#endif
}; };
static __u64 rejects_set_n = ARRAY_SIZE(rejects_set);
#define BASE_SUBLIST \
{ "base", .regs = base_regs, .regs_n = ARRAY_SIZE(base_regs), }
#define VREGS_SUBLIST \
{ "vregs", .regs = vregs, .regs_n = ARRAY_SIZE(vregs), }
#define PMU_SUBLIST \
{ "pmu", .regs = pmu_regs, .regs_n = ARRAY_SIZE(pmu_regs), }
#define SVE_SUBLIST \
{ "sve", .capability = KVM_CAP_ARM_SVE, .feature = KVM_ARM_VCPU_SVE, .finalize = true, \
.regs = sve_regs, .regs_n = ARRAY_SIZE(sve_regs), \
.rejects_set = sve_rejects_set, .rejects_set_n = ARRAY_SIZE(sve_rejects_set), }
static struct vcpu_config vregs_config = {
.sublists = {
BASE_SUBLIST,
VREGS_SUBLIST,
{0},
},
};
static struct vcpu_config vregs_pmu_config = {
.sublists = {
BASE_SUBLIST,
VREGS_SUBLIST,
PMU_SUBLIST,
{0},
},
};
static struct vcpu_config sve_config = {
.sublists = {
BASE_SUBLIST,
SVE_SUBLIST,
{0},
},
};
static struct vcpu_config sve_pmu_config = {
.sublists = {
BASE_SUBLIST,
SVE_SUBLIST,
PMU_SUBLIST,
{0},
},
};
static struct vcpu_config *vcpu_configs[] = {
&vregs_config,
&vregs_pmu_config,
&sve_config,
&sve_pmu_config,
};
static int vcpu_configs_n = ARRAY_SIZE(vcpu_configs);
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment