Commit 30305f58 authored by Harry Wentland's avatar Harry Wentland Committed by Alex Deucher

drm/amd/display: Demote error print to debug print when ATOM impl missing

I assumed wrongfully that all relevant functions should be implemented.
Apparently this isn't the case. Demote the print to debug level for now.
Signed-off-by: default avatarHarry Wentland <harry.wentland@amd.com>
Reviewed-by: default avatarTony Cheng <Tony.Cheng@amd.com>
Acked-by: default avatarHarry Wentland <harry.wentland@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 458d876e
...@@ -387,7 +387,7 @@ static void init_transmitter_control(struct bios_parser *bp) ...@@ -387,7 +387,7 @@ static void init_transmitter_control(struct bios_parser *bp)
bp->cmd_tbl.transmitter_control = transmitter_control_v1_6; bp->cmd_tbl.transmitter_control = transmitter_control_v1_6;
break; break;
default: default:
dm_error("Don't have transmitter_control for v%d\n", crev); dm_output_to_console("Don't have transmitter_control for v%d\n", crev);
bp->cmd_tbl.transmitter_control = NULL; bp->cmd_tbl.transmitter_control = NULL;
break; break;
} }
...@@ -911,7 +911,7 @@ static void init_set_pixel_clock(struct bios_parser *bp) ...@@ -911,7 +911,7 @@ static void init_set_pixel_clock(struct bios_parser *bp)
bp->cmd_tbl.set_pixel_clock = set_pixel_clock_v7; bp->cmd_tbl.set_pixel_clock = set_pixel_clock_v7;
break; break;
default: default:
dm_error("Don't have set_pixel_clock for v%d\n", dm_output_to_console("Don't have set_pixel_clock for v%d\n",
BIOS_CMD_TABLE_PARA_REVISION(SetPixelClock)); BIOS_CMD_TABLE_PARA_REVISION(SetPixelClock));
bp->cmd_tbl.set_pixel_clock = NULL; bp->cmd_tbl.set_pixel_clock = NULL;
break; break;
...@@ -1230,7 +1230,7 @@ static void init_enable_spread_spectrum_on_ppll(struct bios_parser *bp) ...@@ -1230,7 +1230,7 @@ static void init_enable_spread_spectrum_on_ppll(struct bios_parser *bp)
enable_spread_spectrum_on_ppll_v3; enable_spread_spectrum_on_ppll_v3;
break; break;
default: default:
dm_error("Don't have enable_spread_spectrum_on_ppll for v%d\n", dm_output_to_console("Don't have enable_spread_spectrum_on_ppll for v%d\n",
BIOS_CMD_TABLE_PARA_REVISION(EnableSpreadSpectrumOnPPLL)); BIOS_CMD_TABLE_PARA_REVISION(EnableSpreadSpectrumOnPPLL));
bp->cmd_tbl.enable_spread_spectrum_on_ppll = NULL; bp->cmd_tbl.enable_spread_spectrum_on_ppll = NULL;
break; break;
...@@ -1427,7 +1427,7 @@ static void init_adjust_display_pll(struct bios_parser *bp) ...@@ -1427,7 +1427,7 @@ static void init_adjust_display_pll(struct bios_parser *bp)
bp->cmd_tbl.adjust_display_pll = adjust_display_pll_v3; bp->cmd_tbl.adjust_display_pll = adjust_display_pll_v3;
break; break;
default: default:
dm_error("Don't have adjust_display_pll for v%d\n", dm_output_to_console("Don't have adjust_display_pll for v%d\n",
BIOS_CMD_TABLE_PARA_REVISION(AdjustDisplayPll)); BIOS_CMD_TABLE_PARA_REVISION(AdjustDisplayPll));
bp->cmd_tbl.adjust_display_pll = NULL; bp->cmd_tbl.adjust_display_pll = NULL;
break; break;
...@@ -1702,7 +1702,7 @@ static void init_set_crtc_timing(struct bios_parser *bp) ...@@ -1702,7 +1702,7 @@ static void init_set_crtc_timing(struct bios_parser *bp)
set_crtc_using_dtd_timing_v3; set_crtc_using_dtd_timing_v3;
break; break;
default: default:
dm_error("Don't have set_crtc_timing for dtd v%d\n", dm_output_to_console("Don't have set_crtc_timing for dtd v%d\n",
dtd_version); dtd_version);
bp->cmd_tbl.set_crtc_timing = NULL; bp->cmd_tbl.set_crtc_timing = NULL;
break; break;
...@@ -1713,7 +1713,7 @@ static void init_set_crtc_timing(struct bios_parser *bp) ...@@ -1713,7 +1713,7 @@ static void init_set_crtc_timing(struct bios_parser *bp)
bp->cmd_tbl.set_crtc_timing = set_crtc_timing_v1; bp->cmd_tbl.set_crtc_timing = set_crtc_timing_v1;
break; break;
default: default:
dm_error("Don't have set_crtc_timing for v%d\n", dm_output_to_console("Don't have set_crtc_timing for v%d\n",
BIOS_CMD_TABLE_PARA_REVISION(SetCRTC_Timing)); BIOS_CMD_TABLE_PARA_REVISION(SetCRTC_Timing));
bp->cmd_tbl.set_crtc_timing = NULL; bp->cmd_tbl.set_crtc_timing = NULL;
break; break;
...@@ -1901,7 +1901,7 @@ static void init_select_crtc_source(struct bios_parser *bp) ...@@ -1901,7 +1901,7 @@ static void init_select_crtc_source(struct bios_parser *bp)
bp->cmd_tbl.select_crtc_source = select_crtc_source_v3; bp->cmd_tbl.select_crtc_source = select_crtc_source_v3;
break; break;
default: default:
dm_error("Don't select_crtc_source enable_crtc for v%d\n", dm_output_to_console("Don't select_crtc_source enable_crtc for v%d\n",
BIOS_CMD_TABLE_PARA_REVISION(SelectCRTC_Source)); BIOS_CMD_TABLE_PARA_REVISION(SelectCRTC_Source));
bp->cmd_tbl.select_crtc_source = NULL; bp->cmd_tbl.select_crtc_source = NULL;
break; break;
...@@ -2010,7 +2010,7 @@ static void init_enable_crtc(struct bios_parser *bp) ...@@ -2010,7 +2010,7 @@ static void init_enable_crtc(struct bios_parser *bp)
bp->cmd_tbl.enable_crtc = enable_crtc_v1; bp->cmd_tbl.enable_crtc = enable_crtc_v1;
break; break;
default: default:
dm_error("Don't have enable_crtc for v%d\n", dm_output_to_console("Don't have enable_crtc for v%d\n",
BIOS_CMD_TABLE_PARA_REVISION(EnableCRTC)); BIOS_CMD_TABLE_PARA_REVISION(EnableCRTC));
bp->cmd_tbl.enable_crtc = NULL; bp->cmd_tbl.enable_crtc = NULL;
break; break;
...@@ -2118,7 +2118,7 @@ static void init_program_clock(struct bios_parser *bp) ...@@ -2118,7 +2118,7 @@ static void init_program_clock(struct bios_parser *bp)
bp->cmd_tbl.program_clock = program_clock_v6; bp->cmd_tbl.program_clock = program_clock_v6;
break; break;
default: default:
dm_error("Don't have program_clock for v%d\n", dm_output_to_console("Don't have program_clock for v%d\n",
BIOS_CMD_TABLE_PARA_REVISION(SetPixelClock)); BIOS_CMD_TABLE_PARA_REVISION(SetPixelClock));
bp->cmd_tbl.program_clock = NULL; bp->cmd_tbl.program_clock = NULL;
break; break;
...@@ -2341,7 +2341,7 @@ static void init_enable_disp_power_gating( ...@@ -2341,7 +2341,7 @@ static void init_enable_disp_power_gating(
enable_disp_power_gating_v2_1; enable_disp_power_gating_v2_1;
break; break;
default: default:
dm_error("Don't enable_disp_power_gating enable_crtc for v%d\n", dm_output_to_console("Don't enable_disp_power_gating enable_crtc for v%d\n",
BIOS_CMD_TABLE_PARA_REVISION(EnableDispPowerGating)); BIOS_CMD_TABLE_PARA_REVISION(EnableDispPowerGating));
bp->cmd_tbl.enable_disp_power_gating = NULL; bp->cmd_tbl.enable_disp_power_gating = NULL;
break; break;
...@@ -2390,7 +2390,7 @@ static void init_set_dce_clock(struct bios_parser *bp) ...@@ -2390,7 +2390,7 @@ static void init_set_dce_clock(struct bios_parser *bp)
bp->cmd_tbl.set_dce_clock = set_dce_clock_v2_1; bp->cmd_tbl.set_dce_clock = set_dce_clock_v2_1;
break; break;
default: default:
dm_error("Don't have set_dce_clock for v%d\n", dm_output_to_console("Don't have set_dce_clock for v%d\n",
BIOS_CMD_TABLE_PARA_REVISION(SetDCEClock)); BIOS_CMD_TABLE_PARA_REVISION(SetDCEClock));
bp->cmd_tbl.set_dce_clock = NULL; bp->cmd_tbl.set_dce_clock = NULL;
break; break;
......
...@@ -118,7 +118,7 @@ static void init_dig_encoder_control(struct bios_parser *bp) ...@@ -118,7 +118,7 @@ static void init_dig_encoder_control(struct bios_parser *bp)
bp->cmd_tbl.dig_encoder_control = encoder_control_digx_v1_5; bp->cmd_tbl.dig_encoder_control = encoder_control_digx_v1_5;
break; break;
default: default:
dm_error("Don't have dig_encoder_control for v%d\n", version); dm_output_to_console("Don't have dig_encoder_control for v%d\n", version);
bp->cmd_tbl.dig_encoder_control = NULL; bp->cmd_tbl.dig_encoder_control = NULL;
break; break;
} }
...@@ -206,7 +206,7 @@ static void init_transmitter_control(struct bios_parser *bp) ...@@ -206,7 +206,7 @@ static void init_transmitter_control(struct bios_parser *bp)
bp->cmd_tbl.transmitter_control = transmitter_control_v1_6; bp->cmd_tbl.transmitter_control = transmitter_control_v1_6;
break; break;
default: default:
dm_error("Don't have transmitter_control for v%d\n", crev); dm_output_to_console("Don't have transmitter_control for v%d\n", crev);
bp->cmd_tbl.transmitter_control = NULL; bp->cmd_tbl.transmitter_control = NULL;
break; break;
} }
...@@ -270,7 +270,7 @@ static void init_set_pixel_clock(struct bios_parser *bp) ...@@ -270,7 +270,7 @@ static void init_set_pixel_clock(struct bios_parser *bp)
bp->cmd_tbl.set_pixel_clock = set_pixel_clock_v7; bp->cmd_tbl.set_pixel_clock = set_pixel_clock_v7;
break; break;
default: default:
dm_error("Don't have set_pixel_clock for v%d\n", dm_output_to_console("Don't have set_pixel_clock for v%d\n",
BIOS_CMD_TABLE_PARA_REVISION(setpixelclock)); BIOS_CMD_TABLE_PARA_REVISION(setpixelclock));
bp->cmd_tbl.set_pixel_clock = NULL; bp->cmd_tbl.set_pixel_clock = NULL;
break; break;
...@@ -383,7 +383,7 @@ static void init_set_crtc_timing(struct bios_parser *bp) ...@@ -383,7 +383,7 @@ static void init_set_crtc_timing(struct bios_parser *bp)
set_crtc_using_dtd_timing_v3; set_crtc_using_dtd_timing_v3;
break; break;
default: default:
dm_error("Don't have set_crtc_timing for v%d\n", dtd_version); dm_output_to_console("Don't have set_crtc_timing for v%d\n", dtd_version);
bp->cmd_tbl.set_crtc_timing = NULL; bp->cmd_tbl.set_crtc_timing = NULL;
break; break;
} }
...@@ -503,7 +503,7 @@ static void init_select_crtc_source(struct bios_parser *bp) ...@@ -503,7 +503,7 @@ static void init_select_crtc_source(struct bios_parser *bp)
bp->cmd_tbl.select_crtc_source = select_crtc_source_v3; bp->cmd_tbl.select_crtc_source = select_crtc_source_v3;
break; break;
default: default:
dm_error("Don't select_crtc_source enable_crtc for v%d\n", dm_output_to_console("Don't select_crtc_source enable_crtc for v%d\n",
BIOS_CMD_TABLE_PARA_REVISION(selectcrtc_source)); BIOS_CMD_TABLE_PARA_REVISION(selectcrtc_source));
bp->cmd_tbl.select_crtc_source = NULL; bp->cmd_tbl.select_crtc_source = NULL;
break; break;
...@@ -572,7 +572,7 @@ static void init_enable_crtc(struct bios_parser *bp) ...@@ -572,7 +572,7 @@ static void init_enable_crtc(struct bios_parser *bp)
bp->cmd_tbl.enable_crtc = enable_crtc_v1; bp->cmd_tbl.enable_crtc = enable_crtc_v1;
break; break;
default: default:
dm_error("Don't have enable_crtc for v%d\n", dm_output_to_console("Don't have enable_crtc for v%d\n",
BIOS_CMD_TABLE_PARA_REVISION(enablecrtc)); BIOS_CMD_TABLE_PARA_REVISION(enablecrtc));
bp->cmd_tbl.enable_crtc = NULL; bp->cmd_tbl.enable_crtc = NULL;
break; break;
...@@ -670,7 +670,7 @@ static void init_enable_disp_power_gating( ...@@ -670,7 +670,7 @@ static void init_enable_disp_power_gating(
enable_disp_power_gating_v2_1; enable_disp_power_gating_v2_1;
break; break;
default: default:
dm_error("Don't enable_disp_power_gating enable_crtc for v%d\n", dm_output_to_console("Don't enable_disp_power_gating enable_crtc for v%d\n",
BIOS_CMD_TABLE_PARA_REVISION(enabledisppowergating)); BIOS_CMD_TABLE_PARA_REVISION(enabledisppowergating));
bp->cmd_tbl.enable_disp_power_gating = NULL; bp->cmd_tbl.enable_disp_power_gating = NULL;
break; break;
...@@ -721,7 +721,7 @@ static void init_set_dce_clock(struct bios_parser *bp) ...@@ -721,7 +721,7 @@ static void init_set_dce_clock(struct bios_parser *bp)
bp->cmd_tbl.set_dce_clock = set_dce_clock_v2_1; bp->cmd_tbl.set_dce_clock = set_dce_clock_v2_1;
break; break;
default: default:
dm_error("Don't have set_dce_clock for v%d\n", dm_output_to_console("Don't have set_dce_clock for v%d\n",
BIOS_CMD_TABLE_PARA_REVISION(setdceclock)); BIOS_CMD_TABLE_PARA_REVISION(setdceclock));
bp->cmd_tbl.set_dce_clock = NULL; bp->cmd_tbl.set_dce_clock = NULL;
break; break;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment