Commit 30fee1d7 authored by Miaoqian Lin's avatar Miaoqian Lin Committed by Bartosz Golaszewski

gpio: idt3243x: Fix IRQ check in idt_gpio_probe

platform_get_irq() returns negative error number instead 0 on failure.
And the doc of platform_get_irq() provides a usage example:

    int irq = platform_get_irq(pdev, 0);
    if (irq < 0)
        return irq;

Fix the check of return value to catch errors correctly.

Fixes: 4195926a ("gpio: Add support for IDT 79RC3243x GPIO controller")
Signed-off-by: default avatarMiaoqian Lin <linmq006@gmail.com>
Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarBartosz Golaszewski <brgl@bgdev.pl>
parent 0b39536c
...@@ -164,8 +164,8 @@ static int idt_gpio_probe(struct platform_device *pdev) ...@@ -164,8 +164,8 @@ static int idt_gpio_probe(struct platform_device *pdev)
return PTR_ERR(ctrl->pic); return PTR_ERR(ctrl->pic);
parent_irq = platform_get_irq(pdev, 0); parent_irq = platform_get_irq(pdev, 0);
if (!parent_irq) if (parent_irq < 0)
return -EINVAL; return parent_irq;
girq = &ctrl->gc.irq; girq = &ctrl->gc.irq;
girq->chip = &idt_gpio_irqchip; girq->chip = &idt_gpio_irqchip;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment