Commit 32bd29b6 authored by Tomi Valkeinen's avatar Tomi Valkeinen

drm/bridge: tc358767: Fix return value on error case

If the hpd_pin is invalid, the driver returns 'ret'. But 'ret' contains
0, instead of an error value.

Return -EINVAL instead.

Fixes: f25ee501 ("drm/bridge: tc358767: add IRQ and HPD support")
Acked-by: default avatarMaxime Ripard <mripard@kernel.org>
Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20231103-uninit-fixes-v2-4-c22b2444f5f5@ideasonboard.com
parent 155d6fb6
...@@ -2273,7 +2273,7 @@ static int tc_probe(struct i2c_client *client) ...@@ -2273,7 +2273,7 @@ static int tc_probe(struct i2c_client *client)
} else { } else {
if (tc->hpd_pin < 0 || tc->hpd_pin > 1) { if (tc->hpd_pin < 0 || tc->hpd_pin > 1) {
dev_err(dev, "failed to parse HPD number\n"); dev_err(dev, "failed to parse HPD number\n");
return ret; return -EINVAL;
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment