Commit 3309ca6f authored by John Hubbard's avatar John Hubbard Committed by Tejun Heo

selftests/cgroup: cpu_hogger init: use {} instead of {NULL}

First of all, in order to build with clang at all, one must first apply
Valentin Obst's build fix for LLVM [1]. Once that is done, then when
building with clang, via:

    make LLVM=1 -C tools/testing/selftests

...clang generates warning here, because struct cpu_hogger has multiple
fields, and the code is initializing an array of these structs, and it
is incorrect to specify a single NULL value as the initializer.

Fix this by initializing with {}, so that the compiler knows to use
default initializer values for all fields in each array entry.

[1] https://lore.kernel.org/all/20240329-selftests-libmk-llvm-rfc-v1-1-2f9ed7d1c49f@valentinobst.de/Signed-off-by: default avatarJohn Hubbard <jhubbard@nvidia.com>
Reviewed-by: default avatarRoman Gushchin <roman.gushchin@linux.dev>
Signed-off-by: default avatarTejun Heo <tj@kernel.org>
parent 05150894
...@@ -237,7 +237,7 @@ run_cpucg_weight_test( ...@@ -237,7 +237,7 @@ run_cpucg_weight_test(
{ {
int ret = KSFT_FAIL, i; int ret = KSFT_FAIL, i;
char *parent = NULL; char *parent = NULL;
struct cpu_hogger children[3] = {NULL}; struct cpu_hogger children[3] = {};
parent = cg_name(root, "cpucg_test_0"); parent = cg_name(root, "cpucg_test_0");
if (!parent) if (!parent)
...@@ -408,7 +408,7 @@ run_cpucg_nested_weight_test(const char *root, bool overprovisioned) ...@@ -408,7 +408,7 @@ run_cpucg_nested_weight_test(const char *root, bool overprovisioned)
{ {
int ret = KSFT_FAIL, i; int ret = KSFT_FAIL, i;
char *parent = NULL, *child = NULL; char *parent = NULL, *child = NULL;
struct cpu_hogger leaf[3] = {NULL}; struct cpu_hogger leaf[3] = {};
long nested_leaf_usage, child_usage; long nested_leaf_usage, child_usage;
int nprocs = get_nprocs(); int nprocs = get_nprocs();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment