Commit 336eac43 authored by Christophe JAILLET's avatar Christophe JAILLET Committed by David S. Miller

fsl/fman: Remove some useless code

There is no need to release explicitly some devm_ allocated resources.
If the 'mac_probe()' probe function fails, they will be released
automatically, as already done in the other error handling paths of
this function.

Also goto '_return_of_get_parent' as in the other error handling paths.
This is useless (priv->fixed_link is NULL at this point), but at least
it is consistent.
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 5adb55c9
...@@ -709,11 +709,8 @@ static int mac_probe(struct platform_device *_of_dev) ...@@ -709,11 +709,8 @@ static int mac_probe(struct platform_device *_of_dev)
} }
if (!of_device_is_available(mac_node)) { if (!of_device_is_available(mac_node)) {
devm_iounmap(dev, priv->vaddr); err = -ENODEV;
__devm_release_region(dev, fman_get_mem_region(priv->fman), goto _return_of_get_parent;
res.start, res.end + 1 - res.start);
devm_kfree(dev, mac_dev);
return -ENODEV;
} }
/* Get the cell-index */ /* Get the cell-index */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment