Commit 337710b3 authored by Matti Vaittinen's avatar Matti Vaittinen Committed by Mark Brown

regulator: qcom-labibb: Use disable_irq_nosync from isr

Calling the disable_irq() from irq handler might be a bad idea as
disable_irq() should wait for handlers to run. I don't see why
this wouldn't deadlock in wait_event waiting for the threaded
handler to complete.

Use disable_irq_nosync() instead.

Fixes: 390af53e ("regulator: qcom-labibb: Implement short-circuit and over-current IRQs")
Signed-off-by: default avatarMatti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Reviewed-by: default avatarAngeloGioacchino Del Regno  <angelogioacchino.delregno@somainline.org>
Link: https://lore.kernel.org/r/f2c4c88d90bf7473e1b84b8a99b7b33d7a081764.1612249657.git.matti.vaittinen@fi.rohmeurope.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
parent 4288b4cc
...@@ -283,7 +283,7 @@ static irqreturn_t qcom_labibb_ocp_isr(int irq, void *chip) ...@@ -283,7 +283,7 @@ static irqreturn_t qcom_labibb_ocp_isr(int irq, void *chip)
* Disable the interrupt temporarily, or it will fire continuously; * Disable the interrupt temporarily, or it will fire continuously;
* we will re-enable it in the recovery worker function. * we will re-enable it in the recovery worker function.
*/ */
disable_irq(irq); disable_irq_nosync(irq);
/* Warn the user for overcurrent */ /* Warn the user for overcurrent */
dev_warn(vreg->dev, "Over-Current interrupt fired!\n"); dev_warn(vreg->dev, "Over-Current interrupt fired!\n");
...@@ -536,7 +536,7 @@ static irqreturn_t qcom_labibb_sc_isr(int irq, void *chip) ...@@ -536,7 +536,7 @@ static irqreturn_t qcom_labibb_sc_isr(int irq, void *chip)
* Disable the interrupt temporarily, or it will fire continuously; * Disable the interrupt temporarily, or it will fire continuously;
* we will re-enable it in the recovery worker function. * we will re-enable it in the recovery worker function.
*/ */
disable_irq(irq); disable_irq_nosync(irq);
/* Signal out of regulation event to drivers */ /* Signal out of regulation event to drivers */
regulator_notifier_call_chain(vreg->rdev, regulator_notifier_call_chain(vreg->rdev,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment