Commit 3414adbd authored by Sebastian Andrzej Siewior's avatar Sebastian Andrzej Siewior Committed by Jakub Kicinski

lwt: Don't disable migration prio invoking BPF.

There is no need to explicitly disable migration if bottom halves are
also disabled. Disabling BH implies disabling migration.

Remove migrate_disable() and rely solely on disabling BH to remain on
the same CPU.
Signed-off-by: default avatarSebastian Andrzej Siewior <bigeasy@linutronix.de>
Link: https://patch.msgid.link/20240620132727.660738-12-bigeasy@linutronix.deSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent b22800f9
...@@ -40,10 +40,9 @@ static int run_lwt_bpf(struct sk_buff *skb, struct bpf_lwt_prog *lwt, ...@@ -40,10 +40,9 @@ static int run_lwt_bpf(struct sk_buff *skb, struct bpf_lwt_prog *lwt,
{ {
int ret; int ret;
/* Migration disable and BH disable are needed to protect per-cpu /* Disabling BH is needed to protect per-CPU bpf_redirect_info between
* redirect_info between BPF prog and skb_do_redirect(). * BPF prog and skb_do_redirect().
*/ */
migrate_disable();
local_bh_disable(); local_bh_disable();
bpf_compute_data_pointers(skb); bpf_compute_data_pointers(skb);
ret = bpf_prog_run_save_cb(lwt->prog, skb); ret = bpf_prog_run_save_cb(lwt->prog, skb);
...@@ -78,7 +77,6 @@ static int run_lwt_bpf(struct sk_buff *skb, struct bpf_lwt_prog *lwt, ...@@ -78,7 +77,6 @@ static int run_lwt_bpf(struct sk_buff *skb, struct bpf_lwt_prog *lwt,
} }
local_bh_enable(); local_bh_enable();
migrate_enable();
return ret; return ret;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment