Commit 345fef75 authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Mark Brown

spi: spi-sh: fix error return code in spi_sh_probe()

platform_get_irq() returns an error code, but the spi-sh driver
ignores it and always returns -ENODEV. This is not correct and,
prevents -EPROBE_DEFER from being propagated properly.

Print and propagate the return value of platform_get_irq on failure.

This issue was detected with the help of Coccinelle.
Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 5771a8c0
...@@ -446,8 +446,8 @@ static int spi_sh_probe(struct platform_device *pdev) ...@@ -446,8 +446,8 @@ static int spi_sh_probe(struct platform_device *pdev)
irq = platform_get_irq(pdev, 0); irq = platform_get_irq(pdev, 0);
if (irq < 0) { if (irq < 0) {
dev_err(&pdev->dev, "platform_get_irq error\n"); dev_err(&pdev->dev, "platform_get_irq error: %d\n", irq);
return -ENODEV; return irq;
} }
master = spi_alloc_master(&pdev->dev, sizeof(struct spi_sh_data)); master = spi_alloc_master(&pdev->dev, sizeof(struct spi_sh_data));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment