Commit 347db6b4 authored by Xin Long's avatar Xin Long Committed by David S. Miller

bridge: simplify the forward_delay_store by calling store_bridge_parm

There are some repetitive codes in forward_delay_store, we can remove
them by calling store_bridge_parm.
Signed-off-by: default avatarXin Long <lucien.xin@gmail.com>
Reviewed-by: default avatarNikolay Aleksandrov <nikolay@cumulusnetworks.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 14f31bb3
...@@ -160,29 +160,22 @@ static ssize_t group_fwd_mask_show(struct device *d, ...@@ -160,29 +160,22 @@ static ssize_t group_fwd_mask_show(struct device *d,
return sprintf(buf, "%#x\n", br->group_fwd_mask); return sprintf(buf, "%#x\n", br->group_fwd_mask);
} }
static int set_group_fwd_mask(struct net_bridge *br, unsigned long val)
static ssize_t group_fwd_mask_store(struct device *d,
struct device_attribute *attr,
const char *buf,
size_t len)
{ {
struct net_bridge *br = to_bridge(d);
char *endp;
unsigned long val;
if (!ns_capable(dev_net(br->dev)->user_ns, CAP_NET_ADMIN))
return -EPERM;
val = simple_strtoul(buf, &endp, 0);
if (endp == buf)
return -EINVAL;
if (val & BR_GROUPFWD_RESTRICTED) if (val & BR_GROUPFWD_RESTRICTED)
return -EINVAL; return -EINVAL;
br->group_fwd_mask = val; br->group_fwd_mask = val;
return len; return 0;
}
static ssize_t group_fwd_mask_store(struct device *d,
struct device_attribute *attr,
const char *buf,
size_t len)
{
return store_bridge_parm(d, buf, len, set_group_fwd_mask);
} }
static DEVICE_ATTR_RW(group_fwd_mask); static DEVICE_ATTR_RW(group_fwd_mask);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment