Commit 353bbacf authored by Boris Brezillon's avatar Boris Brezillon Committed by Greg Kroah-Hartman

UBI: fastmap: scrub PEB when bitflips are detected in a free PEB EC header

commit ecbfa8ea upstream.

scan_pool() does not mark the PEB for scrubing when bitflips are
detected in the EC header of a free PEB (VID header region left to
0xff).
Make sure we scrub the PEB in this case.
Signed-off-by: default avatarBoris Brezillon <boris.brezillon@free-electrons.com>
Fixes: dbb7d2a8 ("UBI: Add fastmap core")
Signed-off-by: default avatarRichard Weinberger <richard@nod.at>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 1d79b67c
...@@ -513,10 +513,11 @@ static int scan_pool(struct ubi_device *ubi, struct ubi_attach_info *ai, ...@@ -513,10 +513,11 @@ static int scan_pool(struct ubi_device *ubi, struct ubi_attach_info *ai,
unsigned long long ec = be64_to_cpu(ech->ec); unsigned long long ec = be64_to_cpu(ech->ec);
unmap_peb(ai, pnum); unmap_peb(ai, pnum);
dbg_bld("Adding PEB to free: %i", pnum); dbg_bld("Adding PEB to free: %i", pnum);
if (err == UBI_IO_FF_BITFLIPS) if (err == UBI_IO_FF_BITFLIPS)
add_aeb(ai, free, pnum, ec, 1); scrub = 1;
else
add_aeb(ai, free, pnum, ec, 0); add_aeb(ai, free, pnum, ec, scrub);
continue; continue;
} else if (err == 0 || err == UBI_IO_BITFLIPS) { } else if (err == 0 || err == UBI_IO_BITFLIPS) {
dbg_bld("Found non empty PEB:%i in pool", pnum); dbg_bld("Found non empty PEB:%i in pool", pnum);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment