Commit 37bd91d1 authored by David S. Miller's avatar David S. Miller

Merge branch 'qed-next'

Sudarsana Reddy Kalluru says:

====================
qed*: Add support for additional statistics.

The patch series adds qed/qede support for new statistics.
Patch (1) adds couple of statistcs for "ethtool -S" display.
Patch (2) adds support for per-queue statistics to ethtool display.
Patch (3) adds qed support for NCSI statistics.

Please consider applying this to 'net-next' branch.
====================
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parents 0d135e4f 6c754246
...@@ -42,6 +42,8 @@ enum qed_coalescing_mode { ...@@ -42,6 +42,8 @@ enum qed_coalescing_mode {
struct qed_eth_cb_ops; struct qed_eth_cb_ops;
struct qed_dev_info; struct qed_dev_info;
union qed_mcp_protocol_stats;
enum qed_mcp_protocol_type;
/* helpers */ /* helpers */
static inline u32 qed_db_addr(u32 cid, u32 DEMS) static inline u32 qed_db_addr(u32 cid, u32 DEMS)
...@@ -597,7 +599,9 @@ void qed_link_update(struct qed_hwfn *hwfn); ...@@ -597,7 +599,9 @@ void qed_link_update(struct qed_hwfn *hwfn);
u32 qed_unzip_data(struct qed_hwfn *p_hwfn, u32 qed_unzip_data(struct qed_hwfn *p_hwfn,
u32 input_len, u8 *input_buf, u32 input_len, u8 *input_buf,
u32 max_size, u8 *unzip_buf); u32 max_size, u8 *unzip_buf);
void qed_get_protocol_stats(struct qed_dev *cdev,
enum qed_mcp_protocol_type type,
union qed_mcp_protocol_stats *stats);
int qed_slowpath_irq_req(struct qed_hwfn *hwfn); int qed_slowpath_irq_req(struct qed_hwfn *hwfn);
#endif /* _QED_H */ #endif /* _QED_H */
...@@ -7239,6 +7239,12 @@ struct public_drv_mb { ...@@ -7239,6 +7239,12 @@ struct public_drv_mb {
#define DRV_MSG_CODE_MCP_RESET 0x00090000 #define DRV_MSG_CODE_MCP_RESET 0x00090000
#define DRV_MSG_CODE_SET_VERSION 0x000f0000 #define DRV_MSG_CODE_SET_VERSION 0x000f0000
#define DRV_MSG_CODE_GET_STATS 0x00130000
#define DRV_MSG_CODE_STATS_TYPE_LAN 1
#define DRV_MSG_CODE_STATS_TYPE_FCOE 2
#define DRV_MSG_CODE_STATS_TYPE_ISCSI 3
#define DRV_MSG_CODE_STATS_TYPE_RDMA 4
#define DRV_MSG_CODE_BIST_TEST 0x001e0000 #define DRV_MSG_CODE_BIST_TEST 0x001e0000
#define DRV_MSG_CODE_SET_LED_MODE 0x00200000 #define DRV_MSG_CODE_SET_LED_MODE 0x00200000
...@@ -7315,10 +7321,10 @@ enum MFW_DRV_MSG_TYPE { ...@@ -7315,10 +7321,10 @@ enum MFW_DRV_MSG_TYPE {
MFW_DRV_MSG_RESERVED4, MFW_DRV_MSG_RESERVED4,
MFW_DRV_MSG_BW_UPDATE, MFW_DRV_MSG_BW_UPDATE,
MFW_DRV_MSG_BW_UPDATE5, MFW_DRV_MSG_BW_UPDATE5,
MFW_DRV_MSG_BW_UPDATE6, MFW_DRV_MSG_GET_LAN_STATS,
MFW_DRV_MSG_BW_UPDATE7, MFW_DRV_MSG_GET_FCOE_STATS,
MFW_DRV_MSG_BW_UPDATE8, MFW_DRV_MSG_GET_ISCSI_STATS,
MFW_DRV_MSG_BW_UPDATE9, MFW_DRV_MSG_GET_RDMA_STATS,
MFW_DRV_MSG_BW_UPDATE10, MFW_DRV_MSG_BW_UPDATE10,
MFW_DRV_MSG_TRANSCEIVER_STATE_CHANGE, MFW_DRV_MSG_TRANSCEIVER_STATE_CHANGE,
MFW_DRV_MSG_BW_UPDATE11, MFW_DRV_MSG_BW_UPDATE11,
......
...@@ -213,6 +213,8 @@ qed_sp_eth_rx_queues_update(struct qed_hwfn *p_hwfn, ...@@ -213,6 +213,8 @@ qed_sp_eth_rx_queues_update(struct qed_hwfn *p_hwfn,
enum spq_mode comp_mode, enum spq_mode comp_mode,
struct qed_spq_comp_cb *p_comp_data); struct qed_spq_comp_cb *p_comp_data);
void qed_get_vport_stats(struct qed_dev *cdev, struct qed_eth_stats *stats);
int qed_sp_eth_vport_start(struct qed_hwfn *p_hwfn, int qed_sp_eth_vport_start(struct qed_hwfn *p_hwfn,
struct qed_sp_vport_start_params *p_params); struct qed_sp_vport_start_params *p_params);
......
...@@ -1402,3 +1402,24 @@ const struct qed_common_ops qed_common_ops_pass = { ...@@ -1402,3 +1402,24 @@ const struct qed_common_ops qed_common_ops_pass = {
.set_coalesce = &qed_set_coalesce, .set_coalesce = &qed_set_coalesce,
.set_led = &qed_set_led, .set_led = &qed_set_led,
}; };
void qed_get_protocol_stats(struct qed_dev *cdev,
enum qed_mcp_protocol_type type,
union qed_mcp_protocol_stats *stats)
{
struct qed_eth_stats eth_stats;
memset(stats, 0, sizeof(*stats));
switch (type) {
case QED_MCP_LAN_STATS:
qed_get_vport_stats(cdev, &eth_stats);
stats->lan_stats.ucast_rx_pkts = eth_stats.rx_ucast_pkts;
stats->lan_stats.ucast_tx_pkts = eth_stats.tx_ucast_pkts;
stats->lan_stats.fcs_err = -1;
break;
default:
DP_ERR(cdev, "Invalid protocol type = %d\n", type);
return;
}
}
...@@ -713,6 +713,48 @@ int qed_mcp_set_link(struct qed_hwfn *p_hwfn, struct qed_ptt *p_ptt, bool b_up) ...@@ -713,6 +713,48 @@ int qed_mcp_set_link(struct qed_hwfn *p_hwfn, struct qed_ptt *p_ptt, bool b_up)
return 0; return 0;
} }
static void qed_mcp_send_protocol_stats(struct qed_hwfn *p_hwfn,
struct qed_ptt *p_ptt,
enum MFW_DRV_MSG_TYPE type)
{
enum qed_mcp_protocol_type stats_type;
union qed_mcp_protocol_stats stats;
struct qed_mcp_mb_params mb_params;
union drv_union_data union_data;
u32 hsi_param;
switch (type) {
case MFW_DRV_MSG_GET_LAN_STATS:
stats_type = QED_MCP_LAN_STATS;
hsi_param = DRV_MSG_CODE_STATS_TYPE_LAN;
break;
case MFW_DRV_MSG_GET_FCOE_STATS:
stats_type = QED_MCP_FCOE_STATS;
hsi_param = DRV_MSG_CODE_STATS_TYPE_FCOE;
break;
case MFW_DRV_MSG_GET_ISCSI_STATS:
stats_type = QED_MCP_ISCSI_STATS;
hsi_param = DRV_MSG_CODE_STATS_TYPE_ISCSI;
break;
case MFW_DRV_MSG_GET_RDMA_STATS:
stats_type = QED_MCP_RDMA_STATS;
hsi_param = DRV_MSG_CODE_STATS_TYPE_RDMA;
break;
default:
DP_NOTICE(p_hwfn, "Invalid protocol type %d\n", type);
return;
}
qed_get_protocol_stats(p_hwfn->cdev, stats_type, &stats);
memset(&mb_params, 0, sizeof(mb_params));
mb_params.cmd = DRV_MSG_CODE_GET_STATS;
mb_params.param = hsi_param;
memcpy(&union_data, &stats, sizeof(stats));
mb_params.p_data_src = &union_data;
qed_mcp_cmd_and_union(p_hwfn, p_ptt, &mb_params);
}
static void qed_read_pf_bandwidth(struct qed_hwfn *p_hwfn, static void qed_read_pf_bandwidth(struct qed_hwfn *p_hwfn,
struct public_func *p_shmem_info) struct public_func *p_shmem_info)
{ {
...@@ -854,6 +896,12 @@ int qed_mcp_handle_events(struct qed_hwfn *p_hwfn, ...@@ -854,6 +896,12 @@ int qed_mcp_handle_events(struct qed_hwfn *p_hwfn,
case MFW_DRV_MSG_TRANSCEIVER_STATE_CHANGE: case MFW_DRV_MSG_TRANSCEIVER_STATE_CHANGE:
qed_mcp_handle_transceiver_change(p_hwfn, p_ptt); qed_mcp_handle_transceiver_change(p_hwfn, p_ptt);
break; break;
case MFW_DRV_MSG_GET_LAN_STATS:
case MFW_DRV_MSG_GET_FCOE_STATS:
case MFW_DRV_MSG_GET_ISCSI_STATS:
case MFW_DRV_MSG_GET_RDMA_STATS:
qed_mcp_send_protocol_stats(p_hwfn, p_ptt, i);
break;
case MFW_DRV_MSG_BW_UPDATE: case MFW_DRV_MSG_BW_UPDATE:
qed_mcp_update_bw(p_hwfn, p_ptt); qed_mcp_update_bw(p_hwfn, p_ptt);
break; break;
......
...@@ -106,6 +106,47 @@ struct qed_mcp_drv_version { ...@@ -106,6 +106,47 @@ struct qed_mcp_drv_version {
u8 name[MCP_DRV_VER_STR_SIZE - 4]; u8 name[MCP_DRV_VER_STR_SIZE - 4];
}; };
struct qed_mcp_lan_stats {
u64 ucast_rx_pkts;
u64 ucast_tx_pkts;
u32 fcs_err;
};
struct qed_mcp_fcoe_stats {
u64 rx_pkts;
u64 tx_pkts;
u32 fcs_err;
u32 login_failure;
};
struct qed_mcp_iscsi_stats {
u64 rx_pdus;
u64 tx_pdus;
u64 rx_bytes;
u64 tx_bytes;
};
struct qed_mcp_rdma_stats {
u64 rx_pkts;
u64 tx_pkts;
u64 rx_bytes;
u64 tx_byts;
};
enum qed_mcp_protocol_type {
QED_MCP_LAN_STATS,
QED_MCP_FCOE_STATS,
QED_MCP_ISCSI_STATS,
QED_MCP_RDMA_STATS
};
union qed_mcp_protocol_stats {
struct qed_mcp_lan_stats lan_stats;
struct qed_mcp_fcoe_stats fcoe_stats;
struct qed_mcp_iscsi_stats iscsi_stats;
struct qed_mcp_rdma_stats rdma_stats;
};
/** /**
* @brief - returns the link params of the hw function * @brief - returns the link params of the hw function
* *
......
...@@ -36,6 +36,8 @@ ...@@ -36,6 +36,8 @@
struct qede_stats { struct qede_stats {
u64 no_buff_discards; u64 no_buff_discards;
u64 packet_too_big_discard;
u64 ttl0_discard;
u64 rx_ucast_bytes; u64 rx_ucast_bytes;
u64 rx_mcast_bytes; u64 rx_mcast_bytes;
u64 rx_bcast_bytes; u64 rx_bcast_bytes;
...@@ -235,6 +237,7 @@ struct qede_rx_queue { ...@@ -235,6 +237,7 @@ struct qede_rx_queue {
u16 num_rx_buffers; u16 num_rx_buffers;
u16 rxq_id; u16 rxq_id;
u64 rcv_pkts;
u64 rx_hw_errors; u64 rx_hw_errors;
u64 rx_alloc_errors; u64 rx_alloc_errors;
u64 rx_ip_frags; u64 rx_ip_frags;
...@@ -263,6 +266,8 @@ struct qede_tx_queue { ...@@ -263,6 +266,8 @@ struct qede_tx_queue {
union db_prod tx_db; union db_prod tx_db;
u16 num_tx_buffers; u16 num_tx_buffers;
u64 xmit_pkts;
u64 stopped_cnt;
}; };
#define BD_UNMAP_ADDR(bd) HILO_U64(le32_to_cpu((bd)->addr.hi), \ #define BD_UNMAP_ADDR(bd) HILO_U64(le32_to_cpu((bd)->addr.hi), \
......
...@@ -35,6 +35,7 @@ static const struct { ...@@ -35,6 +35,7 @@ static const struct {
u64 offset; u64 offset;
char string[ETH_GSTRING_LEN]; char string[ETH_GSTRING_LEN];
} qede_rqstats_arr[] = { } qede_rqstats_arr[] = {
QEDE_RQSTAT(rcv_pkts),
QEDE_RQSTAT(rx_hw_errors), QEDE_RQSTAT(rx_hw_errors),
QEDE_RQSTAT(rx_alloc_errors), QEDE_RQSTAT(rx_alloc_errors),
QEDE_RQSTAT(rx_ip_frags), QEDE_RQSTAT(rx_ip_frags),
...@@ -44,6 +45,24 @@ static const struct { ...@@ -44,6 +45,24 @@ static const struct {
#define QEDE_RQSTATS_DATA(dev, sindex, rqindex) \ #define QEDE_RQSTATS_DATA(dev, sindex, rqindex) \
(*((u64 *)(((char *)(dev->fp_array[(rqindex)].rxq)) +\ (*((u64 *)(((char *)(dev->fp_array[(rqindex)].rxq)) +\
qede_rqstats_arr[(sindex)].offset))) qede_rqstats_arr[(sindex)].offset)))
#define QEDE_TQSTAT_OFFSET(stat_name) \
(offsetof(struct qede_tx_queue, stat_name))
#define QEDE_TQSTAT_STRING(stat_name) (#stat_name)
#define QEDE_TQSTAT(stat_name) \
{QEDE_TQSTAT_OFFSET(stat_name), QEDE_TQSTAT_STRING(stat_name)}
#define QEDE_NUM_TQSTATS ARRAY_SIZE(qede_tqstats_arr)
static const struct {
u64 offset;
char string[ETH_GSTRING_LEN];
} qede_tqstats_arr[] = {
QEDE_TQSTAT(xmit_pkts),
QEDE_TQSTAT(stopped_cnt),
};
#define QEDE_TQSTATS_DATA(dev, sindex, tssid, tcid) \
(*((u64 *)(((u64)(&dev->fp_array[tssid].txqs[tcid])) +\
qede_tqstats_arr[(sindex)].offset)))
static const struct { static const struct {
u64 offset; u64 offset;
char string[ETH_GSTRING_LEN]; char string[ETH_GSTRING_LEN];
...@@ -107,6 +126,8 @@ static const struct { ...@@ -107,6 +126,8 @@ static const struct {
QEDE_PF_STAT(mftag_filter_discards), QEDE_PF_STAT(mftag_filter_discards),
QEDE_PF_STAT(mac_filter_discards), QEDE_PF_STAT(mac_filter_discards),
QEDE_STAT(tx_err_drop_pkts), QEDE_STAT(tx_err_drop_pkts),
QEDE_STAT(ttl0_discard),
QEDE_STAT(packet_too_big_discard),
QEDE_STAT(coalesced_pkts), QEDE_STAT(coalesced_pkts),
QEDE_STAT(coalesced_events), QEDE_STAT(coalesced_events),
...@@ -151,17 +172,29 @@ static void qede_get_strings_stats(struct qede_dev *edev, u8 *buf) ...@@ -151,17 +172,29 @@ static void qede_get_strings_stats(struct qede_dev *edev, u8 *buf)
{ {
int i, j, k; int i, j, k;
for (i = 0, k = 0; i < edev->num_rss; i++) {
int tc;
for (j = 0; j < QEDE_NUM_RQSTATS; j++)
sprintf(buf + (k + j) * ETH_GSTRING_LEN,
"%d: %s", i, qede_rqstats_arr[j].string);
k += QEDE_NUM_RQSTATS;
for (tc = 0; tc < edev->num_tc; tc++) {
for (j = 0; j < QEDE_NUM_TQSTATS; j++)
sprintf(buf + (k + j) * ETH_GSTRING_LEN,
"%d.%d: %s", i, tc,
qede_tqstats_arr[j].string);
k += QEDE_NUM_TQSTATS;
}
}
for (i = 0, j = 0; i < QEDE_NUM_STATS; i++) { for (i = 0, j = 0; i < QEDE_NUM_STATS; i++) {
if (IS_VF(edev) && qede_stats_arr[i].pf_only) if (IS_VF(edev) && qede_stats_arr[i].pf_only)
continue; continue;
strcpy(buf + j * ETH_GSTRING_LEN, strcpy(buf + (k + j) * ETH_GSTRING_LEN,
qede_stats_arr[i].string); qede_stats_arr[i].string);
j++; j++;
} }
for (k = 0; k < QEDE_NUM_RQSTATS; k++, j++)
strcpy(buf + j * ETH_GSTRING_LEN,
qede_rqstats_arr[k].string);
} }
static void qede_get_strings(struct net_device *dev, u32 stringset, u8 *buf) static void qede_get_strings(struct net_device *dev, u32 stringset, u8 *buf)
...@@ -197,19 +230,24 @@ static void qede_get_ethtool_stats(struct net_device *dev, ...@@ -197,19 +230,24 @@ static void qede_get_ethtool_stats(struct net_device *dev,
mutex_lock(&edev->qede_lock); mutex_lock(&edev->qede_lock);
for (qid = 0; qid < edev->num_rss; qid++) {
int tc;
for (sidx = 0; sidx < QEDE_NUM_RQSTATS; sidx++)
buf[cnt++] = QEDE_RQSTATS_DATA(edev, sidx, qid);
for (tc = 0; tc < edev->num_tc; tc++) {
for (sidx = 0; sidx < QEDE_NUM_TQSTATS; sidx++)
buf[cnt++] = QEDE_TQSTATS_DATA(edev, sidx, qid,
tc);
}
}
for (sidx = 0; sidx < QEDE_NUM_STATS; sidx++) { for (sidx = 0; sidx < QEDE_NUM_STATS; sidx++) {
if (IS_VF(edev) && qede_stats_arr[sidx].pf_only) if (IS_VF(edev) && qede_stats_arr[sidx].pf_only)
continue; continue;
buf[cnt++] = QEDE_STATS_DATA(edev, sidx); buf[cnt++] = QEDE_STATS_DATA(edev, sidx);
} }
for (sidx = 0; sidx < QEDE_NUM_RQSTATS; sidx++) {
buf[cnt] = 0;
for (qid = 0; qid < edev->num_rss; qid++)
buf[cnt] += QEDE_RQSTATS_DATA(edev, sidx, qid);
cnt++;
}
mutex_unlock(&edev->qede_lock); mutex_unlock(&edev->qede_lock);
} }
...@@ -227,7 +265,8 @@ static int qede_get_sset_count(struct net_device *dev, int stringset) ...@@ -227,7 +265,8 @@ static int qede_get_sset_count(struct net_device *dev, int stringset)
if (qede_stats_arr[i].pf_only) if (qede_stats_arr[i].pf_only)
num_stats--; num_stats--;
} }
return num_stats + QEDE_NUM_RQSTATS; return num_stats + edev->num_rss *
(QEDE_NUM_RQSTATS + QEDE_NUM_TQSTATS * edev->num_tc);
case ETH_SS_PRIV_FLAGS: case ETH_SS_PRIV_FLAGS:
return QEDE_PRI_FLAG_LEN; return QEDE_PRI_FLAG_LEN;
case ETH_SS_TEST: case ETH_SS_TEST:
......
...@@ -720,6 +720,7 @@ static netdev_tx_t qede_start_xmit(struct sk_buff *skb, ...@@ -720,6 +720,7 @@ static netdev_tx_t qede_start_xmit(struct sk_buff *skb,
if (unlikely(qed_chain_get_elem_left(&txq->tx_pbl) if (unlikely(qed_chain_get_elem_left(&txq->tx_pbl)
< (MAX_SKB_FRAGS + 1))) { < (MAX_SKB_FRAGS + 1))) {
netif_tx_stop_queue(netdev_txq); netif_tx_stop_queue(netdev_txq);
txq->stopped_cnt++;
DP_VERBOSE(edev, NETIF_MSG_TX_QUEUED, DP_VERBOSE(edev, NETIF_MSG_TX_QUEUED,
"Stop queue was called\n"); "Stop queue was called\n");
/* paired memory barrier is in qede_tx_int(), we have to keep /* paired memory barrier is in qede_tx_int(), we have to keep
...@@ -779,6 +780,7 @@ static int qede_tx_int(struct qede_dev *edev, struct qede_tx_queue *txq) ...@@ -779,6 +780,7 @@ static int qede_tx_int(struct qede_dev *edev, struct qede_tx_queue *txq)
bytes_compl += len; bytes_compl += len;
pkts_compl++; pkts_compl++;
txq->sw_tx_cons++; txq->sw_tx_cons++;
txq->xmit_pkts++;
} }
netdev_tx_completed_queue(netdev_txq, pkts_compl, bytes_compl); netdev_tx_completed_queue(netdev_txq, pkts_compl, bytes_compl);
...@@ -1587,6 +1589,8 @@ static int qede_rx_int(struct qede_fastpath *fp, int budget) ...@@ -1587,6 +1589,8 @@ static int qede_rx_int(struct qede_fastpath *fp, int budget)
/* Update producers */ /* Update producers */
qede_update_rx_prod(edev, rxq); qede_update_rx_prod(edev, rxq);
rxq->rcv_pkts += rx_pkt;
return rx_pkt; return rx_pkt;
} }
...@@ -1694,6 +1698,8 @@ void qede_fill_by_demand_stats(struct qede_dev *edev) ...@@ -1694,6 +1698,8 @@ void qede_fill_by_demand_stats(struct qede_dev *edev)
edev->ops->get_vport_stats(edev->cdev, &stats); edev->ops->get_vport_stats(edev->cdev, &stats);
edev->stats.no_buff_discards = stats.no_buff_discards; edev->stats.no_buff_discards = stats.no_buff_discards;
edev->stats.packet_too_big_discard = stats.packet_too_big_discard;
edev->stats.ttl0_discard = stats.ttl0_discard;
edev->stats.rx_ucast_bytes = stats.rx_ucast_bytes; edev->stats.rx_ucast_bytes = stats.rx_ucast_bytes;
edev->stats.rx_mcast_bytes = stats.rx_mcast_bytes; edev->stats.rx_mcast_bytes = stats.rx_mcast_bytes;
edev->stats.rx_bcast_bytes = stats.rx_bcast_bytes; edev->stats.rx_bcast_bytes = stats.rx_bcast_bytes;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment