Commit 37e444c8 authored by Daniel M German's avatar Daniel M German Committed by Felipe Balbi

usb: Replace snprintf with scnprintf in gether_get_ifname

snprintf returns the actual length of the buffer created; however,
this is not the case if snprintf truncates its parameter.
See https://lwn.net/Articles/69419/ for a detailed explanation.
The current code correctly handles this case at the expense
of extra code in the return statement.

scnprintf does returns the actual length of the buffer created
making the ?: operator unnecessary in the return
statement.

This change does not alter the functionality of the code.
Signed-off-by: default avatarDaniel M German <dmg@turingmachine.org>
Signed-off-by: default avatarFelipe Balbi <felipe.balbi@linux.intel.com>
parent d29fcf70
...@@ -1006,9 +1006,9 @@ int gether_get_ifname(struct net_device *net, char *name, int len) ...@@ -1006,9 +1006,9 @@ int gether_get_ifname(struct net_device *net, char *name, int len)
int ret; int ret;
rtnl_lock(); rtnl_lock();
ret = snprintf(name, len, "%s\n", netdev_name(net)); ret = scnprintf(name, len, "%s\n", netdev_name(net));
rtnl_unlock(); rtnl_unlock();
return ret < len ? ret : len; return ret;
} }
EXPORT_SYMBOL_GPL(gether_get_ifname); EXPORT_SYMBOL_GPL(gether_get_ifname);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment